Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename self to window #238

Closed
niftylettuce opened this issue Nov 29, 2015 · 4 comments
Closed

rename self to window #238

niftylettuce opened this issue Nov 29, 2015 · 4 comments

Comments

@niftylettuce
Copy link

otherwise we can't have tests that run on a node runtime environment simulating a browser (e.g. using jsdom or jsdomify)

@stkrzysiak
Copy link

@niftylettuce I keep stumbling on your comments, I think we've been having some of the same grievances lately. Have you considered using isomorphic-fetch as a work around? That is my current plan of attack with this.

@niftylettuce
Copy link
Author

yes I have and check out my pull request and project called Frisbee
On Nov 30, 2015 10:03 AM, "Steve Krzysiak" notifications@github.com wrote:

@niftylettuce https://github.com/niftylettuce I keep stumbling on your
comments, I think we've been having some of the same grievances lately.
Have you considered using isomorphic-fetch as a work around? That is my
current plan of attack with this.


Reply to this email directly or view it on GitHub
#238 (comment).

@niftylettuce
Copy link
Author

@niftylettuce
Copy link
Author

@stkrzysiak ignore this -- I have to patch and use jsdom instead of jsdomify per jsdom/jsdom#1203 (comment)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants