-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework (v3) #71
base: master
Are you sure you want to change the base?
Rework (v3) #71
Conversation
@JakeSidSmith is there anything we can do to help you out? Maybe create some examples? I'm using version 2.1.0 and it works great on desktop, but has problems on mobile, so I'm looking forward to this PR. |
@HriBB I've been pretty busy, but feel free to fork from this branch & contribute. When you're happy, open a PR against this branch. :) Was going to sort out the auto-scrolling next, but have to make sure this is accounted for. You can have a go at that if you like? One thing to bare in mind, I'm changing the auto-scroll area bounds a little. They should be 33.33% of the width / height... but no larger than 20px or so (have not decided on an exact value yet). This way there's a 33.33% dead zone in the center, but shouldn't take up so much room on large containers. Got a start & watch script for the examples (where I've been testing stuff). npm start
npm run watch |
This reverts commit cb08fae.
Would love to see this PR merged and 3.0 to become an official non-alpha release. |
Fix typo in example
I have already switched, and agree that the api is much better and that v3 works much better. Thus I would recommend merging this PR and releasing 3.0.0, and then addressing the remaining items in follow up releases. |
Alternatively do a beta release, because "alpha" does not do justice to how well v3 works :) |
moved everything from componentwillmount to componentdidmount
Before alpha release (3.0.0-alpha.0)
toArray
on Immutable Lists)(or between them)
autoScroll
autoScrollParents
autoScrollWindow
data-reorder-disabled
propdraggable={false}
to prevent image draggingNext
Soon (Possibly)