Add DrawScope.drawCircle
#529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this looks fine as far as the code goes. I guess my only question is... would someone actually use this? Circles on a monospace grid don't seem all that useful. I could see someone using braille characters (a little like https://chipaca.com/en/2024/01/xbmbraille/), but I don't want to provide that in the core. I'd be open to another module with braille-shape drawing primitives, though. |
EpicDima
force-pushed
the
epicdima/draw_circle
branch
from
6e6208a to
20def02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of pictures
CHANGELOG.md's "Unreleased" section has been updated, if applicable.