Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alias loader support for pjson.alias a& recommend pjson.imports #20

Closed
JakobJingleheimer opened this issue Aug 31, 2024 · 4 comments · Fixed by #35
Closed

Remove alias loader support for pjson.alias a& recommend pjson.imports #20

JakobJingleheimer opened this issue Aug 31, 2024 · 4 comments · Fixed by #35
Milestone

Comments

@JakobJingleheimer
Copy link
Owner

The current alias field is obsolete with package.json subimports

@JakobJingleheimer JakobJingleheimer added this to the v2 milestone Aug 31, 2024
@AugustinMauroy
Copy link
Collaborator

-1 to remove it but why not add mention. Because there some framework put alias on their boilerplate (nextjs, gatsby, remix, nuxt)

@JakobJingleheimer
Copy link
Owner Author

Hmm? I'm not proposing removing the whole loader, just the part that looks for an "aliases" within package.json (because it's now redundant to the standard "imports" field).

@AugustinMauroy
Copy link
Collaborator

AugustinMauroy commented Nov 15, 2024

maybe just drop support of alias in package.json so just support ts alias. And create a codmode

@JakobJingleheimer
Copy link
Owner Author

Ah! Yes, should do as part of the v2.0 release. Good catch. Will try to get done today (unless you wanna do—should be just deleting a few lines of code, the test cases for it, and removing part of the readme).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants