feat(alias loader): drop package.json support #35
Conversation
There was a problem hiding this comment.
I think this loader should be marked @deprecated with a link to the readme explaining to use pjson imports
There was a problem hiding this comment.
not fan of that because this ts feature isn't deprecated. So +1 to invite user to go on subpath but still usefull for some user.
There was a problem hiding this comment.
Also not sure if web pack and other handle sub path for front end code. Because aliases can be used in react app.
There was a problem hiding this comment.
tsconfig "paths" is an abortion of a feature (my stackoverflow post "Why are these tsconfig paths not working?" has like a million hits) that has plagued the ecosystem for neigh a decade. I think we should do everything we can to encourage users against it. I think marking it deprecated is appropriate because it should be removed as soon as possible: subpath imports is a far better option.
There was a problem hiding this comment.
I suggest we leave it like that here. Because it will really help people (example nodejs.org 😅). And we resume the discussion on nodejs with a codemod in our hands
The README didn't mention support of |
Correct. It should. |
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
JakobJingleheimer
changed the title
Resolves #20