Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tsx): use swc #10

Closed
wants to merge 6 commits into from

Conversation

AugustinMauroy
Copy link
Collaborator

  • reduce dependency size by 20KO
  • it's supposed to perform better

https://swc.rs/docs/benchmarks

tsx.mjs Outdated Show resolved Hide resolved
@JakobJingleheimer
Copy link
Owner

The benchmarks on that link appear to be broken: there's only 1 bar or line in the charts.

@AugustinMauroy
Copy link
Collaborator Author

The benchmarks on that link appear to be broken: there's only 1 bar or line in the charts.

did you opened an issue on their repo ?

@JakobJingleheimer
Copy link
Owner

No, not yet. Wanted to check with you because you saw it working before (so checking with you that what you saw before is not what you see now).

@AugustinMauroy
Copy link
Collaborator Author

AugustinMauroy commented Jul 13, 2024

@JakobJingleheimer should I also syncify tsx on this pr ????

My advice is to land this pr like this and make a refracto from behind to syncify all.

@JakobJingleheimer
Copy link
Owner

JakobJingleheimer commented Aug 4, 2024

The benchmarks on that link appear to be broken: there's only 1 bar or line in the charts.

did you opened an issue on their repo ?

This was apparently a choice:

kdy1 commented on Apr 22
I removed the benchmark CI action because of the CI cost. I think we should document it

@JakobJingleheimer
Copy link
Owner

I would not combine those changes for a couple reasons:

  1. Syncification has not landed in node, so this hook would be broken when used with another hook that is async (because this hook would fail to await the other).
  2. They can't be backed out independently, and they're not related.

I already have a PR to syncify the hooks btw: #16. Syncifying introduces a non-trivial performance degradation (which I raised to node), which needs to be explored.

README.md Outdated Show resolved Hide resolved
tsx.mjs Show resolved Hide resolved
tsx.mjs Show resolved Hide resolved
tsx.spec.mjs Show resolved Hide resolved
AugustinMauroy and others added 2 commits August 4, 2024 16:17
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
@AugustinMauroy
Copy link
Collaborator Author

The decision in the project is not to support/create a loader if one is already official.
https://github.com/swc-project/swc-node/tree/master/packages/register#swc-noderegister

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants