-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tsx): use swc #10
Conversation
The benchmarks on that link appear to be broken: there's only 1 bar or line in the charts. |
did you opened an issue on their repo ? |
No, not yet. Wanted to check with you because you saw it working before (so checking with you that what you saw before is not what you see now). |
@JakobJingleheimer should I also syncify tsx on this pr ???? My advice is to land this pr like this and make a refracto from behind to syncify all. |
I would not combine those changes for a couple reasons:
I already have a PR to syncify the hooks btw: #16. Syncifying introduces a non-trivial performance degradation (which I raised to node), which needs to be explored. |
Co-authored-by: Jacob Smith <3012099+JakobJingleheimer@users.noreply.github.com>
The decision in the project is not to support/create a loader if one is already official. |
https://swc.rs/docs/benchmarks