Add SpacePilot DeviceSpec #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a
DeviceSpecfor my SpacePilot device. Tested on Linux.This device has an LCD screen, but no LEDs. I set
led_idtoNoneto reflect this. It seems likeled_idis currently unused (looks like easyhid has no output support, where the original repo used pywinusb instead?). If you add back LED support, just make sure to test ifled_idisNonebefore using it, shouldn't be an issue.I wasn't sure if there was any particular order of the buttons, I put them in order of each bit and byte. The comments reflect the labelling of the physical buttons.
I copied the axis mappings from the SpacePilot Pro and tested the motion of each axis to verify it's correct.