Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom collapse breakpoint feature #17

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Custom collapse breakpoint feature #17

merged 2 commits into from
Jul 27, 2022

Conversation

BranislavMateas
Copy link
Contributor

Hello everyone! So basically, I was using your package in my project, but I ran into this problem so I thought and told myself that it would be great to have the ability to set the custom breakpoint, when will our menu collapse. And so, I delivered. Hope you like it (and merge it 😁).

Signed by Branislav Mateáš.

@Jamalianpour
Copy link
Owner

Hello and thank you,
Can you change the name of sideMenuBreakpoint? I thinks that's a little confusing.
And don't use sideMenu in name.

@BranislavMateas
Copy link
Contributor Author

BranislavMateas commented Jul 27, 2022

I think the collapseWidth might be less confusing. Better?

@Jamalianpour Jamalianpour merged commit b785616 into Jamalianpour:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants