feat(html): Handle mismatched tags #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-LG
commented
Jul 17, 2023
Comment on lines
+38
to
+72
| pub struct ParseOptionsBuilder { | ||
| reducers: Vec<Box<dyn FnOnce(ParseOptions) -> ParseOptions>>, | ||
| } | ||
|
|
||
| impl ParseOptionsBuilder { | ||
| /// Creates a new [ParseOptionsBuilder]. | ||
| pub fn new() -> Self { | ||
| Self { | ||
| reducers: Vec::new(), | ||
| } | ||
| } | ||
|
|
||
| /// Set the type of [MismatchedTagHandler] the parser should use. | ||
| pub fn with_mismatched_tag_handler(mut self, handler: Box<dyn MismatchedTagHandler>) -> Self { | ||
| let reducer = |options| ParseOptions { | ||
| mismatched_tag_handler: handler, | ||
| ..options | ||
| }; | ||
| self.reducers.push(Box::new(reducer)); | ||
| self | ||
| } | ||
|
|
||
| /// Build the [ParseOptions]. | ||
| pub fn build(self) -> ParseOptions { | ||
| self.reducers | ||
| .into_iter() | ||
| .fold(ParseOptions::new(), |options, f| f(options)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Order of builder method calls in maintained with self.reducers.
James-LG
commented
Jul 17, 2023
src/html/mod.rs
Outdated
|
|
||
| match html_node { | ||
| HtmlNode::Tag(tag) => { | ||
| // TODO: Deal with auto-closed tags like <br> |
There was a problem hiding this comment.
Note to self: Still some TODOs lurking
James-LG
force-pushed
the
jameslg/malformed_handler
branch
from
49d022a to
ffac82f
Compare
- Adds an extension point for handling mismatched tags in malformed HTML - Adds several mismatched tag handlers - Implements Display on HtmlDocument
James-LG
force-pushed
the
jameslg/malformed_handler
branch
from
ffac82f to
2fc5295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13