Zz/bringmybracketback

[innerlee]

Fix #854
Also re-fix #609

[jlelong]

This breaks snippet nesting, which was the main issue about snippets and using ${1}.

Without your PR: \(@a\) expands to \(\alpha\).
With it: \(@a\) does not expand. TAB just jumps out of the \(...\).

[tecosaur]

Do you know if there might be any way to force vs code to expand a snippet if it can, then only if it can't move on to the next $ region.

[jlelong]

Indeed, I have searched a lot for this and never found anything interesting. So I guess it a no.

[innerlee]

I do not understand the concept of nesting.

For the link #609 (comment), we can auto complete brackets in math mode with this pr, so no need to type __<tab>-like things.

For the @a example, I cannot make it work on my machine. Do I need to turn on any option to get the @something nesting?

[jlelong]

There is a weird play between snippets starting in \ and others (especially those starting in @).

Hitting TAB on @a leads to \alpha, even though the menu completion may not show up, see the end of #669. With your PR, this is not possible inside \(...\).

[innerlee]

Cannot get it working with the version on marketplace

[jlelong]

Have checked that you have "editor.tabCompletion": true?

[innerlee]

Both true or false do not work.
latexworkshop version 5.11.1
vscode version 1.27.2
win10

[jlelong]

Have you tried playing a bit with "editor.wordBasedSuggestions": false/true and "editor.quickSuggestions": false/true?
A few people have already reported this but we have never managed to understand what was happening. Maybe this time...

[Astrantia]

@jlelong i'll jump in. having both quicksuggestions and wordBasedSuggestions set to true, I still don't get any suggestions when I type @ . I do get a suggestion when I type @a, but no suggestions for @%, no suggestions for @8, etc...

[innerlee]

Tried the 8 combinations, none works. Maybe conflict with some other extensions?

btw, this is not a judgement or anything, and I appreciate the typing habits from other software.
But by suggesting completion items (suggest \alpha when typing \a) as in https://code.visualstudio.com/updates/v1_25#_suggestion-selections, we can provide a more natural experience to autocomplete \alpha, without typing the @ symbol.
So I would like to suggest remove the @thing feature.

[Astrantia]

@innerlee I wouldn't agree. I like @ more. Those who use latex frequently will easily familiarize themselves with @ and the convenience it provides vs \ is big, because \ is already overpopulated with suggestions

[jlelong]

As @Astrantia pointed out, the completion list for \a is so huge, \alpha is only on 18th position and you have to type \al to have it on the first completion screen. The @ snippets are designed such that two prefixes cannot start with a common substring. Moreover, \ requires more keystrokes (3 on my layout) than @ on many keyboard layouts.

[Astrantia]

@jlelong Why does this happen though?

[jlelong]

This is related to vscode#35651
Intellisense does not take into account non alphabetical characters, hence the long list you get. But, no matter the list, the snippet you expect is always the first one!

[Astrantia]

@jlelong You misunderstood the point of the gif. I expect to get suggestions for @8, @/, @% as they are also defined, but im only getting suggestions for @alphabet chars

[Astrantia]

@jlelong https://github.com/James-Yu/LaTeX-Workshop/blob/master/snippets/latex.json#L42
Notice that it doesn't appear in my gif.

[Astrantia]

Update: I had to set "editor.tabCompletion": "onlySnippets" for @% + Tab to expand the snippet. I still don't get suggestion pop-up, but tabbing works now.

[innerlee]

okay, I will wait for microsoft/vscode#45385

[innerlee]

For anyone interested, here is a extension file with this pr merged. https://github.com/innerlee/LaTeX-Workshop/releases/tag/v5.11.1