Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use captureStr #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: use captureStr #2

wants to merge 6 commits into from

Conversation

fgdorais
Copy link
Contributor

I thought your parser capture idea was really cool, so I added it to lean4-parser. Since I grabbed the name, this breaks your code. Here are proposed fixes.

@fgdorais
Copy link
Contributor Author

fgdorais commented Dec 23, 2023 •
edited
Loading

I'm thinking I was too quick picking this capture API. I think you're use case where the parser output is dropped is probably a primary use. I'm thinking about revising the API with two interfaces: withCapture and dropCapture. What do you think? That way, dropCaptureString would be a drop-in replacement for your original capture parser.

@fgdorais fgdorais changed the title feat: use captureString feat: use captureStr Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgdorais @JamesGallicchio