-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remote urls pattern #369
Conversation
It does need fixing but your suggested change would not accept both secure/nonsecure URLs. It should be: |
Hi @JamesHeinrich sorry, i write more faster than my mind. I add test to prevent the future errors. I think in make a method to download locally elements and analyze in temporaly storage and delete in the end. You like? I can put this in a new PR. You have any board or list with the features or things to do? What it's the older PHP version supported in version 2? Regards! |
Bugfixes should go to the
Downloading files from external sources is not specifically supported, getID3 only works with local files. So it is the user's responsibility to download the file to a local storage for further analysis. Lines 174 to 206 in 81cf18e
Now the technically minimum supported version for GetID3 2.x is PHP 5.4 (as specified in composer.json). The plans are to bump this version to |
Add secure urls to expression