Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 fixes: warning for required after optional param and fatal errors for non-existing methods when Debus is ON #185

Merged
merged 1 commit into from
Nov 20, 2021
Merged

PHP 8 fixes: warning for required after optional param and fatal errors for non-existing methods when Debus is ON #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phpthumb.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4139,8 +4139,8 @@ public function phpThumbDebug($level='') {
$DebugOutput[] = 'getenv(DOCUMENT_ROOT) = '.@getenv('DOCUMENT_ROOT');
$DebugOutput[] = '';

$DebugOutput[] = 'get_magic_quotes_gpc() = '.$this->phpThumbDebugVarDump(@get_magic_quotes_gpc());
$DebugOutput[] = 'get_magic_quotes_runtime() = '.$this->phpThumbDebugVarDump(@get_magic_quotes_runtime());
$DebugOutput[] = 'get_magic_quotes_gpc() = '.(function_exists('get_magic_quotes_gpc') ? $this->phpThumbDebugVarDump(@get_magic_quotes_gpc()) : false);
$DebugOutput[] = 'get_magic_quotes_runtime() = '.(function_exists('get_magic_quotes_runtime') ? $this->phpThumbDebugVarDump(@get_magic_quotes_runtime()) : false);
$DebugOutput[] = 'error_reporting() = '.$this->phpThumbDebugVarDump(error_reporting());
$DebugOutput[] = 'ini_get(error_reporting) = '.$this->phpThumbDebugVarDump(@ini_get('error_reporting'));
$DebugOutput[] = 'ini_get(display_errors) = '.$this->phpThumbDebugVarDump(@ini_get('display_errors'));
Expand Down
2 changes: 1 addition & 1 deletion phpthumb.filters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,7 @@ public function ImageBorder(&$gdimg, $border_width, $radius_x, $radius_y, $hexco
}


public static function ImprovedImageRotate(&$gdimg_source, $rotate_angle=0, $config_background_hexcolor='FFFFFF', $bg=null, &$phpThumbObject) {
public static function ImprovedImageRotate(&$gdimg_source, $rotate_angle=0, $config_background_hexcolor='FFFFFF', $bg=null, &$phpThumbObject = null) {
while ($rotate_angle < 0) {
$rotate_angle += 360;
}
Expand Down