You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciscorn
changed the title
Export basic types that appear in arguments and return values
chore(terra-draw): Export basic types that appear in arguments and return values
Jan 22, 2025
Right you are about HexColor. I think I was remembering HexColorStyling which does not appear to be exported. As for TerraDrawBaseSelectMode, the documentation states that you should be able to provide your own select mode. The private getSelectMode() method casts to TerraDrawBaseSelectMode. This function is internal, but it is called by public methods that rely on the methods defined in that base class. So, it seems like it should be exported in support of custom select modes; otherwise you have to hope a custom select mode's methods line up with it without type support.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ciscorn
changed the title
Description of Changes
This PR exports some basic types that appear in the arguments and return types of the user-facing interfaces.
Link to Issue
Resolves #439
PR Checklist
If I have added significant code changes, there are relevant testsIf there are behaviour changes these are documented