Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(terra-draw): Export basic types that appear in arguments and return values #440

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −23
Open

chore(terra-draw): Export basic types that appear in arguments and return values #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1552d8d
Export basic types that appear in arguments and return values
ciscorn Jan 22, 2025
6d47f45
export TerraDrawBaseSelectMode
ciscorn Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 29 additions & 23 deletions packages/terra-draw/src/terra-draw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class TerraDraw {
});

const getChanged = (
ids: FeatureId[],
ids: FeatureId[]
): {
changed: GeoJSONStoreFeatures[];
unchanged: GeoJSONStoreFeatures[];
Expand Down Expand Up @@ -197,7 +197,7 @@ class TerraDraw {
unchanged,
updated: [],
},
this.getModeStyles(),
this.getModeStyles()
);
} else if (event === "update") {
this._adapter.render(
Expand All @@ -207,17 +207,17 @@ class TerraDraw {
unchanged,
updated: changed,
},
this.getModeStyles(),
this.getModeStyles()
);
} else if (event === "delete") {
this._adapter.render(
{ created: [], deletedIds: ids, unchanged, updated: [] },
this.getModeStyles(),
this.getModeStyles()
);
} else if (event === "styling") {
this._adapter.render(
{ created: [], deletedIds: [], unchanged, updated: [] },
this.getModeStyles(),
this.getModeStyles()
);
}
};
Expand All @@ -235,7 +235,7 @@ class TerraDraw {

this._adapter.render(
{ created: [], deletedIds: [], unchanged, updated: changed },
this.getModeStyles(),
this.getModeStyles()
);
};

Expand All @@ -261,7 +261,7 @@ class TerraDraw {
unchanged,
updated: changed,
},
this.getModeStyles(),
this.getModeStyles()
);
}
};
Expand All @@ -275,7 +275,7 @@ class TerraDraw {
project: this._adapter.project.bind(this._adapter),
unproject: this._adapter.unproject.bind(this._adapter),
setDoubleClickToZoom: this._adapter.setDoubleClickToZoom.bind(
this._adapter,
this._adapter
),
onChange: onChange,
onSelect: onSelect,
Expand Down Expand Up @@ -305,7 +305,7 @@ class TerraDraw {
feature.properties[SELECT_PROPERTIES.SELECTED]
) {
return this._modes[this._instanceSelectMode].styleFeature.bind(
this._modes[this._instanceSelectMode],
this._modes[this._instanceSelectMode]
)(feature);
}

Expand All @@ -324,7 +324,7 @@ class TerraDraw {
lng: number;
lat: number;
},
options?: { pointerDistance: number; ignoreSelectFeatures: boolean },
options?: { pointerDistance: number; ignoreSelectFeatures: boolean }
) {
const pointerDistance =
options && options.pointerDistance !== undefined
Expand Down Expand Up @@ -374,7 +374,7 @@ class TerraDraw {
const distanceToLine = pixelDistanceToLine(
inputPoint,
project(coord[0], coord[1]),
project(nextCoord[0], nextCoord[1]),
project(nextCoord[0], nextCoord[1])
);

if (distanceToLine < pointerDistance) {
Expand All @@ -385,7 +385,7 @@ class TerraDraw {
} else {
const lngLatInsidePolygon = pointInPolygon(
[lng, lat],
feature.geometry.coordinates,
feature.geometry.coordinates
);

if (lngLatInsidePolygon) {
Expand Down Expand Up @@ -427,7 +427,7 @@ class TerraDraw {
*/
setModeStyles<Styling extends Record<string, number | HexColor>>(
mode: string,
styles: Styling,
styles: Styling
) {
this.checkEnabled();
if (!this._modes[mode]) {
Expand Down Expand Up @@ -619,8 +619,8 @@ class TerraDraw {
const reason = validationResult.reason
? validationResult.reason
: !validationResult.valid
? "Feature is invalid"
: undefined;
? "Feature is invalid"
: undefined;
return {
id: (feature as { id?: FeatureId }).id,
valid,
Expand Down Expand Up @@ -695,7 +695,7 @@ class TerraDraw {
*/
getFeaturesAtLngLat(
lngLat: { lng: number; lat: number },
options?: { pointerDistance: number; ignoreSelectFeatures: boolean },
options?: { pointerDistance: number; ignoreSelectFeatures: boolean }
) {
const { lng, lat } = lngLat;

Expand All @@ -704,7 +704,7 @@ class TerraDraw {
lng,
lat,
},
options,
options
);
}

Expand All @@ -717,10 +717,10 @@ class TerraDraw {
*/
getFeaturesAtPointerEvent(
event: PointerEvent | MouseEvent,
options?: { pointerDistance: number; ignoreSelectFeatures: boolean },
options?: { pointerDistance: number; ignoreSelectFeatures: boolean }
) {
const getLngLatFromEvent = this._adapter.getLngLatFromEvent.bind(
this._adapter,
this._adapter
);

const lngLat = getLngLatFromEvent(event);
Expand Down Expand Up @@ -755,7 +755,7 @@ class TerraDraw {
*/
on<T extends TerraDrawEvents>(
event: T,
callback: TerraDrawEventListeners[T],
callback: TerraDrawEventListeners[T]
) {
const listeners = this._eventListeners[
event
Expand All @@ -775,7 +775,7 @@ class TerraDraw {
*/
off<T extends TerraDrawEvents>(
event: TerraDrawEvents,
callback: TerraDrawEventListeners[T],
callback: TerraDrawEventListeners[T]
) {
const listeners = this._eventListeners[
event
Expand Down Expand Up @@ -805,14 +805,20 @@ export {
// Types that are required for 3rd party developers to extend
TerraDrawExtend,

// TerraDrawBaseMode
// Basic types that appear in the public API
BehaviorConfig,
FeatureId,
GeoJSONStoreFeatures,
GeoJSONStoreGeometries,
HexColor,
TerraDrawMouseEvent,
IdStrategy,
TerraDrawAdapterStyling,
TerraDrawBaseDrawMode,
TerraDrawBaseSelectMode,
TerraDrawEventListeners,
TerraDrawEvents,
TerraDrawKeyboardEvent,
TerraDrawMouseEvent,

// TerraDrawBaseAdapter
TerraDrawChanges,
Expand Down