bugfix for setting IsOptional on nullable types #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I pulled the HttpParameter building out into its own class so that I could make sure there were tests around it. I didnt try to inject it into PostBuild because I wasnt sure what side effects that might induce. I also didnt write any tests around the FormParameters as I didnt have a good example.
I had some issues with the existing tests not running. I dont know if thats my setup or what. I do know that both Resharper and NCrunch dont like assemblies with the Functions SKD because it alters the output of the binaries in a non-standard way. As a solution I only have the Functions SDK in my very top level lib, and everything else has the needed dependencies (hence the change to the integration tests proj). Let me know if you want me to change up anything, or feel free to discard. :)