Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Added the allowed_paths_regex subrule #34

Merged

Conversation

acecilia
Copy link
Contributor

@acecilia acecilia commented Aug 27, 2019

See the tests for examples.

The functionality added in this PR may solve issues #16 and #20

Copy link
Contributor

@Jeehut Jeehut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few details, but looks good overall. Can be merged once the small things are fixed.

Sources/ProjLintKit/Rules/FileExistenceRule.swift Outdated Show resolved Hide resolved
Tests/ProjLintKitTests/Rules/FileExistenceRuleTests.swift Outdated Show resolved Hide resolved
Tests/ProjLintKitTests/Rules/FileExistenceRuleTests.swift Outdated Show resolved Hide resolved
Tests/ProjLintKitTests/Rules/FileExistenceRuleTests.swift Outdated Show resolved Hide resolved
Tests/ProjLintKitTests/Rules/FileExistenceRuleTests.swift Outdated Show resolved Hide resolved
@acecilia
Copy link
Contributor Author

acecilia commented Sep 9, 2019

@Dschee would it be possible to have this merged and a new release?

@Jeehut Jeehut merged commit 2101228 into JamitLabs:stable Sep 11, 2019
@Jeehut
Copy link
Contributor

Jeehut commented Sep 11, 2019

Merged and released. Thank you for your contributions! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants