Token drift #95
Merged
Token drift #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamzTheMan
added
bug
MapTool
JamzTheMan
approved these changes
Sep 29, 2018
|
FYI: I keep reading this as Tokyo Drift.... :) |
JamzTheMan
added a commit
that referenced
this pull request
Nov 11, 2018
Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan
added
investigating
JamzTheMan
added a commit
that referenced
this pull request
Nov 14, 2018
* Fixed #4 (#95) Created next-release branch for testing. * Updating next-release (#105) * Update issue templates * Update issue templates * Added Submit a Question template with support links. * Removed Mobile related sections * Added MapTool version section for Bug Report * Create CODE_OF_CONDUCT.md (#97) * Create CODE_OF_CONDUCT.md * Update build.gradle removed markdown files from spotless * Added some files to .gitignore, removed auto-generated file, and added jacoco to build.gradle (#104) * Fix setTokenOpacity to update token for players. (#108) * Update issue templates * Update issue templates * Added Submit a Question template with support links. * Removed Mobile related sections * Added MapTool version section for Bug Report * Create CODE_OF_CONDUCT.md (#97) * Create CODE_OF_CONDUCT.md * Update build.gradle removed markdown files from spotless * Added some files to .gitignore, removed auto-generated file, and added jacoco to build.gradle (#104) * Fix setTokenOpacity to update token for players. * Ran spotlessCheck to fix style issues. * Bug fix release 1.4.5.4 (#114) * Update issue templates * Update issue templates * Added Submit a Question template with support links. * Removed Mobile related sections * Added MapTool version section for Bug Report * Create CODE_OF_CONDUCT.md (#97) * Create CODE_OF_CONDUCT.md * Update build.gradle removed markdown files from spotless * Added some files to .gitignore, removed auto-generated file, and added jacoco to build.gradle (#104) * Enhancement - getMoveCount function * Added optional 2nd parameter to getMoveCount(returnFractional, userTerrainModifiers) macro function to return distanced traveled using terrain modifiers. First parameter, returnFractional, if true, ignores 2nd parameter and returns 1 if last move was a fraction, eg for 1-2-1 movement tracking. * 113: Macro function getMoveCount() does not return terrain modifier costs * Hack to get JDK 10 from my server and manually extract for AppVeyor - Linux. Hopefully this works! Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net> * 113: Macro function getMoveCount() does not return terrain modifier costs * Hack to get JDK 10 from my server and manually extract for AppVeyor - Linux. Hopefully this works this time! Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net> * 113: Macro function getMoveCount() does not return terrain modifier costs * Hack to get JDK 10 from my server and manually extract for AppVeyor - Linux. Hopefully this works this time! * helps to untar java dir not under project dir Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net> * 113: Macro function getMoveCount() does not return terrain modifier costs * Debugging deploy on Linux Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net> * 113: Macro function getMoveCount() does not return terrain modifier costs * Debugging deploy on linux Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net> * 113: Macro function getMoveCount() does not return terrain modifier costs * Debugging deploy on linux Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net> * 113: Macro function getMoveCount() does not return terrain modifier costs * Debugging deploy on linux Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net> * #113: Macro function getMoveCount() does not return terrain modfier costs * Changelog updated, Ready for release 1.4.5.4! Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net> * Appveyor cleanup... * Changelog updates. * Removing fix for #95 Task-Url: #113 Signed-off-by: Jamz <Jamz@Nerps.net>
|
@kayila Do we have this tracked in RPTools/maptool? I'm trying to move what we need from this fork back to RPTools. |
|
Not as far as I know.
…On Sat, Mar 16, 2019, 09:57 Jamz ***@***.***> wrote:
@kayila <https://github.com/kayila> Do we have this tracked in
RPTools/maptool? I'm trying to move what we need from this fork back to
RPTools.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA4eM-_hyZtKRzN2GlX3sYv8FApG1Claks5vXPg3gaJpZM4W-YWt>
.
|
|
I believe what you had finished here and merged is now in RPTools. Can you verify that? So what is left, IIRC is phase 2 as this merge still didn't fix all if this. Is this related to what Jagged is working on for hex drag? |
|
I can confirm that this is not in rptools. I believe since it didn't fix the full problem, you rolled it back. We should open a new issue in the rptools repo and handle it in there. I believe Jagged's work may fix this, so I'd like to wait for them to finish before taking another look at this issue. |
|
Ok, no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.