Enhancement: Add tests where prophesize(), willExtend(), and willImpl…

…ement() are used in helper method
Jan0707 · Mar 1, 2020 · 23ded47 · 23ded47
1 parent 9cfcd2a
commit 23ded47
Show file tree

Hide file tree

Showing 5 changed files with 99 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -65,6 +65,19 @@ final class ExampleTest extends Framework\TestCase
 
         // ...
     }
+
+    public function testSomethingDifferent(): void
+    {
+        $testDouble = $this->createProphecy()->reveal();
+
+        // ...
+    }
+
+    private function createProphecy()
+    {
+        return $this->prophesize(SomeModel::class);
+    }
+
 }
 ```
 
@@ -101,6 +114,18 @@ final class ExampleTest extends Framework\TestCase
 
         // ...
     }
+
+    public function testSomethingDifferent(): void
+    {
+        $testDouble = $this->createProphecy()->reveal();
+
+        // ...
+    }
+
+    private function createProphecy()
+    {
+        return $this->prophesize(SomeModel::class)->willExtend(SomeInterface::class);
+    }
 }
 ```
 
@@ -137,6 +162,18 @@ final class ExampleTest extends Framework\TestCase
 
         // ...
     }
+
+    public function testSomethingDifferent(): void
+    {
+        $testDouble = $this->createProphecy()->reveal();
+
+        // ...
+    }
+
+    private function createProphecy()
+    {
+        return $this->prophesize(SomeModel::class)->willImplement(SomeInterface::class);
+    }
 }
 ```
 

diff --git a/phpstan.neon b/phpstan.neon
@@ -3,6 +3,7 @@ includes:
 
 parameters:
 	ignoreErrors:
+		- '#^Method .* has no return typehint specified\.$#'
 		- '#^Property .* has no typehint specified\.$#'
 	inferPrivatePropertyTypeFromConstructor: true
 	level: max

diff --git a/test/StaticAnalysis/Test/ObjectProphecy/ProphesizeTest.php b/test/StaticAnalysis/Test/ObjectProphecy/ProphesizeTest.php
@@ -64,4 +64,27 @@ public function testInTestMethod(): void
         self::assertEquals('bar', $testDouble->getFoo());
         self::assertEquals(5, $testDouble->doubleTheNumber(2));
     }
+
+    public function testInHelperMethod(): void
+    {
+        $prophecy = $this->createProphecy();
+
+        $prophecy
+            ->getFoo()
+            ->willReturn('bar');
+
+        $prophecy
+            ->doubleTheNumber(Argument::is(2))
+            ->willReturn(5);
+
+        $testDouble = $prophecy->reveal();
+
+        self::assertEquals('bar', $testDouble->getFoo());
+        self::assertEquals(5, $testDouble->doubleTheNumber(2));
+    }
+
+    private function createProphecy()
+    {
+        return $this->prophesize(Src\BaseModel::class);
+    }
 }
diff --git a/test/StaticAnalysis/Test/ObjectProphecy/WillExtendTest.php b/test/StaticAnalysis/Test/ObjectProphecy/WillExtendTest.php
@@ -55,4 +55,23 @@ public function testInTestMethod(): void
 
         self::assertSame('Hmm', $subject->baz($prophecy->reveal()));
     }
+
+    public function testInHelperMethod(): void
+    {
+        $prophecy = $this->createProphecy();
+
+        $prophecy
+            ->baz()
+            ->shouldBeCalled()
+            ->willReturn('Hmm');
+
+        $subject = new Src\BaseModel();
+
+        self::assertSame('Hmm', $subject->baz($prophecy->reveal()));
+    }
+
+    private function createProphecy()
+    {
+        return $this->prophesize()->willExtend(Src\Baz::class);
+    }
 }
diff --git a/test/StaticAnalysis/Test/ObjectProphecy/WillImplementTest.php b/test/StaticAnalysis/Test/ObjectProphecy/WillImplementTest.php
@@ -55,4 +55,23 @@ public function testInTestMethod(): void
 
         self::assertSame('Oh', $subject->bar($prophecy->reveal()));
     }
+
+    public function testInHelperMethod(): void
+    {
+        $prophecy = $this->createProphecy();
+
+        $prophecy
+            ->bar()
+            ->shouldBeCalled()
+            ->willReturn('Oh');
+
+        $subject = new Src\BaseModel();
+
+        self::assertSame('Oh', $subject->bar($prophecy->reveal()));
+    }
+
+    private function createProphecy()
+    {
+        return $this->prophesize(Src\Foo::class)->willImplement(Src\Bar::class);
+    }
 }