Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHPUnit 10 & 11 #334

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Allow PHPUnit 10 & 11 #334

merged 2 commits into from
Apr 3, 2024

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Apr 3, 2024

This pull request

  • Allows the installation of this package alongside PHPUnit 10 & 11

Related to #332.

I started getting CI failures since 1.0.1 due to the inclusion of #332; before, the conflict rule was broken and allowed me to use this package happily with PHPUnit 10 and 11: https://github.com/facile-it/paraunit/actions/runs/8432471574/job/23091610492#step:4:109

@Jean85 Jean85 requested a review from Jan0707 as a code owner April 3, 2024 08:05
@alexander-schranz
Copy link
Collaborator

alexander-schranz commented Apr 3, 2024

yeah PHPUnit 10 and 11 was currently not official suppored or tested. The conflict was written false which did allow still the installation. But fine to open the version constraint if you didn't have any problems with it.

Thx for the PR.

@alexander-schranz alexander-schranz merged commit 5ee56c7 into Jan0707:master Apr 3, 2024
14 checks passed
@Jean85 Jean85 deleted the patch-1 branch April 3, 2024 08:27
@Jean85
Copy link
Contributor Author

Jean85 commented Apr 3, 2024

Thank you for the quick merge! I would advise to change the CI though, because you're not testing with 10 and 11 in any case here, and you also need to test with the prophecy-phpunit trait too then.

@mmross
Copy link

mmross commented Apr 15, 2024

It seems that this update is not yet included in any tag, when will this happen? Many thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants