Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set package type to "phpstan-extension" #47

Merged
merged 1 commit into from
Jul 31, 2019
Merged

set package type to "phpstan-extension" #47

merged 1 commit into from
Jul 31, 2019

Conversation

Taluu
Copy link
Contributor

@Taluu Taluu commented May 20, 2019

So that this extension can be managed through the brand new extension-installer from phpstan

@Jan0707
Copy link
Owner

Jan0707 commented May 27, 2019

@Taluu Checks failed and files have conflict, please resolve those first :)

@Jan0707
Copy link
Owner

Jan0707 commented May 27, 2019

Also, for anyone who is new to this, this is what @Taluu is referring to: https://github.com/phpstan/extension-installer

@Taluu Taluu force-pushed the phpstan-extension branch from 0a57f7f to 9c90721 Compare May 28, 2019 13:57
@Taluu
Copy link
Contributor Author

Taluu commented May 28, 2019

Rebased, and conflict fixed. :}

@Taluu Taluu force-pushed the phpstan-extension branch from 9c90721 to 865168d Compare May 28, 2019 13:59
@Jan0707
Copy link
Owner

Jan0707 commented Jun 11, 2019

Sorry, failed. Please normalise your composer.json file :) Then we should be good to go!

@Taluu Taluu force-pushed the phpstan-extension branch from 865168d to 8d54351 Compare June 11, 2019 11:26
@carusogabriel
Copy link

Can we please have this one merged and released? 😇

localheinz
localheinz approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@icanhazstring
Copy link

@Jan0707 could we merge this? :)

@core23
Copy link

core23 commented Jul 27, 2019

You should add a short note in the README.md file, that this is possible now

@Jan0707 Jan0707 merged commit 23301ff into Jan0707:master Jul 31, 2019
@Jan0707
Copy link
Owner

Jan0707 commented Jul 31, 2019

Merged. Tagged. Releases. :) Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

@core23 core23 core23 approved these changes

@localheinz localheinz localheinz approved these changes

@mavimo mavimo mavimo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Taluu @Jan0707 @carusogabriel @icanhazstring @core23 @mavimo @localheinz @Jean85