Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency on leading and trailing diamonds not working #1634

Closed
1 task done
Victoria-DR opened this issue Jan 23, 2022 · 3 comments
Closed
1 task done

Transparency on leading and trailing diamonds not working #1634

Victoria-DR opened this issue Jan 23, 2022 · 3 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@Victoria-DR
Copy link
Contributor

Victoria-DR commented Jan 23, 2022

Code of Conduct

  • I agree to follow this project's Code of Conduct

What happened?

I'm using Oh My Posh v6.44.1 7.5.1 (just tried this with the latest version and the issue still persists), Windows Terminal, and Powershell. The issue occurs in both Powershell v5 and v7. I followed this tutorial.

The triangles circled in red in the image below should not appear; those areas should be transparent. The first theme is night-owl and the second is clean-detailed.

image

It looks like there might be two things happening, though take this with a grain of salt. First, it's failing to apply transparent to leading and trailing diamonds, and rather uses the colour value of the foreground attribute.

Second, it looks like there's an error in the night-owl theme where the trailing diamond has the wrong second colour value for the java block. Instead of "trailing_diamond": "<transparent,#0e8ac8>\uE0B2</>",, it should be "trailing_diamond": "<transparent,#ffffff>\uE0B2</>",. This would make it consistent with all the other blocks, where the second colour values for the leading and trailing diamonds are the same as the colour values of the background attributes.

Theme

I'm using night-owl, but the same issue persists no matter what the theme is.

What OS are you seeing the problem on?

Windows

Which shell are you using?

powershell

Log output

2022/01/23 16:17:53 debug: getenv
C:\Users\Victoria\AppData\Local
2022/01/23 16:17:53 getenv duration: 0s, args: LOCALAPPDATA
2022/01/23 16:17:53 getCachePath duration: 0s, args:
2022/01/23 16:17:53 getArgs duration: 0s, args:
2022/01/23 16:17:53 getArgs duration: 0s, args:
2022/01/23 16:17:53 getShellName duration: 19.5465ms, args:
2022/01/23 16:17:53 debug: getenv

2022/01/23 16:17:53 getenv duration: 0s, args: OMP_CACHE_DISABLED
2022/01/23 16:17:53 isRunningAsRoot duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getShellName duration: 0s, args:
2022/01/23 16:17:53 getCurrentUser duration: 0s, args:
2022/01/23 16:17:53 getHostName duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getRuntimeGOOS duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getShellName duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 executionTime duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getRuntimeGOOS duration: 0s, args:
2022/01/23 16:17:53 hasCommand duration: 4.975ms, args: git.exe
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 hasParentFilePath duration: 0s, args: .git
2022/01/23 16:17:53 debug: runCommand
# branch.oid d2bf48543a0c79f9ac271db3e688af73c284b45b
# branch.head main
# branch.upstream origin/main
# branch.ab +0 -0
2022/01/23 16:17:53 runCommand duration: 178.8853ms, args: git.exe -C C:\Users\Victoria\Documents\GitHub\2021OffSeason\ --no-optional-locks -c core.quotepath=false -c color.status=false status -unormal --branch --porcelain=2
2022/01/23 16:17:53 hasFolder duration: 0s, args: C:\Users\Victoria\Documents\GitHub\2021OffSeason\.git/rebase-merge
2022/01/23 16:17:53 hasFolder duration: 0s, args: C:\Users\Victoria\Documents\GitHub\2021OffSeason\.git/rebase-apply
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 hasFilesInDir duration: 0s, args: MERGE_MSG
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 hasFilesInDir duration: 0s, args: CHERRY_PICK_HEAD
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 hasFilesInDir duration: 0s, args: REVERT_HEAD
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 hasFilesInDir duration: 0s, args: sequencer/todo
2022/01/23 16:17:53 error: getFileContent
open C:\Users\Victoria\Documents\GitHub\2021OffSeason\.git/logs/refs/stash: The system cannot find the file specified.
2022/01/23 16:17:53 getFileContent duration: 0s, args: C:\Users\Victoria\Documents\GitHub\2021OffSeason\.git/logs/refs/stash
2022/01/23 16:17:53 hasFolder duration: 0s, args: C:\Users\Victoria\Documents\GitHub\2021OffSeason\.git/worktrees
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 isRunningAsRoot duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getShellName duration: 0s, args:
2022/01/23 16:17:53 getCurrentUser duration: 0s, args:
2022/01/23 16:17:53 getHostName duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 isRunningAsRoot duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 getArgs duration: 0s, args:
2022/01/23 16:17:53 getRuntimeGOOS duration: 0s, args:
2022/01/23 16:17:53 getRuntimeGOOS duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getPathSeperator duration: 0s, args:
2022/01/23 16:17:53 getRuntimeGOOS duration: 0s, args:
2022/01/23 16:17:53 isWsl duration: 0s, args:
2022/01/23 16:17:53 stackCount duration: 0s, args:
2022/01/23 16:17:53 getcwd duration: 0s, args:
2022/01/23 16:17:53 lastErrorCode duration: 0s, args:
@Victoria-DR Victoria-DR added the 🐛 bug Something isn't working label Jan 23, 2022
@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Jan 23, 2022

@Victoria-DR thanks for the detailed analysis. Unfortunately, this is a bug in Windows Terminal. They've been holding back a fix for quite a while now.

The Java segment indeed seems to have a glitch in the theme. You can file a PR for that or I can check it.

@Victoria-DR
Copy link
Contributor Author

Thanks for letting me know, hopefully they'll fix it soon. I just submitted a PR for the Java segment.

Copy link

github-actions bot commented Mar 4, 2024

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants