Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing diamond colour in Java block #1635

Merged
merged 1 commit into from
Jan 23, 2022
Merged

Fix trailing diamond colour in Java block #1635

merged 1 commit into from
Jan 23, 2022

Conversation

Victoria-DR
Copy link
Contributor

@Victoria-DR Victoria-DR commented Jan 23, 2022

Prerequisites

  • I have read and understood the CONTRIBUTING guide
  • The commit message follows the conventional commits guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes/features)

Description

Updates colour for the trailing diamond in the Java block so that it is the same as the colour of the background attribute. Mentioned in #1634.

@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Jan 23, 2022

@Victoria-DR can you reword the commit message to comply with the conventional commit guidelines? There's a guide here if you don't know how.

@JanDeDobbeleer JanDeDobbeleer merged commit 5588a32 into JanDeDobbeleer:main Jan 23, 2022
@JanDeDobbeleer
Copy link
Owner

I squashed it, so don't worry anymore (bit tired here I guess).

@all-contributors please add @Victoria-DR for design

@allcontributors
Copy link
Contributor

@JanDeDobbeleer

I've put up a pull request to add @Victoria-DR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants