Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux i686 #4397

Closed
1 task done
duckfromdiscord opened this issue Oct 28, 2023 · 10 comments
Closed
1 task done

Linux i686 #4397

duckfromdiscord opened this issue Oct 28, 2023 · 10 comments
Assignees
Labels
🚀 feat New feature

Comments

@duckfromdiscord
Copy link

Code of Conduct

  • I agree to follow this project's Code of Conduct

What would you like to see changed/added?

Running the install script shows: "i686 builds for linux are not available for Oh My Posh". It would be great to have an installer for i386/i686/32-bit Linux.

@JanDeDobbeleer
Copy link
Owner

We don't even build it for that architecture, and in 2023 I don't see the use-case myself. Can you explain where you would need this?

@duckfromdiscord
Copy link
Author

iSH! It runs 32-bit Alpine Linux, and I'm trying to bring nushell + oh-my-posh to all of my personal devices.

JanDeDobbeleer added a commit that referenced this issue Oct 29, 2023
JanDeDobbeleer added a commit that referenced this issue Oct 29, 2023
JanDeDobbeleer added a commit that referenced this issue Oct 29, 2023
@duckfromdiscord
Copy link
Author

Thank you! Especially for such a quick response! I'm testing it now.

@JanDeDobbeleer
Copy link
Owner

JanDeDobbeleer commented Oct 29, 2023

@duckfromdiscord it doesn't work. The installation succeeds but there's an issue in an underlying package (gopsutil) that causes a panic. I'll have a look to see if I can patch that.

EDIT: traced it all the way to here. That needs to be checked to be >= 8 as that assumption is being made down the line.

@duckfromdiscord
Copy link
Author

Thank you. In case it helps, here's the error running just oh-my-posh with no arguments:

panic: runtime error: index out of range [5] with length 5

goroutine 1 [running]:
github.com/shirou/gopsutil/v3/cpu.parseStatLine({0x9130210, 0x23})
        /opt/hostedtoolcache/go/pkg/mod/github.com/shirou/gopsutil/v3@v3.23.9/cpu/cpu_linux.go:340 +0x5db
github.com/shirou/gopsutil/v3/cpu.TimesWithContext({0x8a01990, 0x8f189c0}, 0x0)
        /opt/hostedtoolcache/go/pkg/mod/github.com/shirou/gopsutil/v3@v3.23.9/cpu/cpu_linux.go:119 +0x2d0
github.com/shirou/gopsutil/v3/cpu.Times(...)
        /opt/hostedtoolcache/go/pkg/mod/github.com/shirou/gopsutil/v3@v3.23.9/cpu/cpu_linux.go:95
github.com/shirou/gopsutil/v3/cpu.init.0()
        /opt/hostedtoolcache/go/pkg/mod/github.com/shirou/gopsutil/v3@v3.23.9/cpu/cpu.go:62 +0x44

I've also asked the devs in the iSH server.

@JanDeDobbeleer
Copy link
Owner

Yup, same issue. But this is on our end, and could be a rabbit hole. This isn't a real linux distro.

@duckfromdiscord
Copy link
Author

If we rebuilt gopsutil with that patch, could it be fixed?

@JanDeDobbeleer
Copy link
Owner

@duckfromdiscord maybe. I'm trying that tomorrow.

@JanDeDobbeleer
Copy link
Owner

@duckfromdiscord confirmed to work, that said, configuring the terminal correctly on iSH is a whole other challenge (font, rendering, etc).

Copy link

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀 feat New feature
Projects
None yet
Development

No branches or pull requests

2 participants