Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White background or light themes compatibility #497

Closed
2 tasks done
betancour opened this issue Mar 8, 2021 · 3 comments
Closed
2 tasks done

White background or light themes compatibility #497

betancour opened this issue Mar 8, 2021 · 3 comments

Comments

@betancour
Copy link

Prerequisites

  • I have read and understand the CONTRIBUTING guide
  • I looked for duplicate issues before submitting this one

Description

[Description of the bug or feature]

Environment

  • Oh my Posh version: v2
  • Theme:
  • Operating System: Windows10 PS
  • Shell: PS
  • Terminal: Windows Terminal

Steps to Reproduce

  1. [First Step]
    Use any white or light background theme

Expected behavior: [What you expected to happen]
non display black colors and maintain the shape of markers
Actual behavior: [What actually happened]

Post black paths inside the markers

image

@JanDeDobbeleer
Copy link
Owner

@betancour that's a Windows Terminal issue. I'll reproduce this on iTerm just to be 100% sure but it's known that Windows Terminal has issues with inverted ANSI.

@JanDeDobbeleer
Copy link
Owner

@betancour confirmed:

screen.mp4

JanDeDobbeleer added a commit that referenced this issue Mar 14, 2021
relates to #529
relates to #322
relates to #497

Windors terminal and Visual Studio Code do not work well with inversted
ANSI sequences. This weak allows users to override the Tranparency to
the terminal background color removing black elements in their prompt.

Ideally we remove this once they are on par with other terminals, but
that could take a while.

See microsoft/vscode#111762
and microsoft/terminal#7014
JanDeDobbeleer added a commit that referenced this issue Mar 14, 2021
relates to #529
relates to #322
relates to #497

Windors terminal and Visual Studio Code do not work well with inversted
ANSI sequences. This weak allows users to override the Tranparency to
the terminal background color removing black elements in their prompt.

Ideally we remove this once they are on par with other terminals, but
that could take a while.

See microsoft/vscode#111762
and microsoft/terminal#7014
Copy link

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues.
If you have found a problem that seems similar, please open a discussion first, complete the body with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants