-
Notifications
You must be signed in to change notification settings - Fork 38
fix: skip adding another plan when no data file groups left during table scan #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! I can have a look at the error. Looks like something with Materialized Views. |
a99cabe to
ba5d824
Compare
Oh thanks, just force-pushed a fix before seeing your message. It seems that sometimes there can be no plans and no data file groups either, so in that case it's useful to use the no-op plan. |
|
That said it might be a bit more elegant to not rely on the no-op/empty parquet scan and instead be more explicit with match plans.len() {
0 => {
let projected_schema = projection
.map(|p| arrow_schema.project(&p))
.transpose()?
.unwrap_or(arrow_schema.as_ref().clone());
Ok(Arc::new(EmptyExec::new(Arc::new(projected_schema))))
}
1 => Ok(plans.remove(0)),
_ => Ok(Arc::new(UnionExec::new(plans))),
}Let me know what you think about that. |
|
Yeah, I think that would be best. Thanks again! |
ba5d824 to
a48d48e
Compare
fix: skip adding another plan when no data file groups left during table scan
fix: skip adding another plan when no data file groups left during table scan
fix: skip adding another plan when no data file groups left during table scan
fix: skip adding another plan when no data file groups left during table scan
fix: skip adding another plan when no data file groups left during table scan
fix: skip adding another plan when no data file groups left during table scan
Closes #217.