Skip to content

Conversation

@gruuya
Copy link
Contributor

@gruuya gruuya commented Jul 30, 2025

Closes #217.

@JanKaul
Copy link
Owner

JanKaul commented Jul 30, 2025

Thanks for the PR! I can have a look at the error. Looks like something with Materialized Views.

@gruuya gruuya force-pushed the equality-delete-scan-fix branch from a99cabe to ba5d824 Compare July 30, 2025 06:16
@gruuya
Copy link
Contributor Author

gruuya commented Jul 30, 2025

Thanks for the PR! I can have a look at the error. Looks like something with Materialized Views.

Oh thanks, just force-pushed a fix before seeing your message.

It seems that sometimes there can be no plans and no data file groups either, so in that case it's useful to use the no-op plan.

@gruuya
Copy link
Contributor Author

gruuya commented Jul 30, 2025

That said it might be a bit more elegant to not rely on the no-op/empty parquet scan and instead be more explicit with

    match plans.len() {
        0 => {
            let projected_schema = projection
                .map(|p| arrow_schema.project(&p))
                .transpose()?
                .unwrap_or(arrow_schema.as_ref().clone());
            Ok(Arc::new(EmptyExec::new(Arc::new(projected_schema))))
        }
        1 => Ok(plans.remove(0)),
        _ => Ok(Arc::new(UnionExec::new(plans))),
    }

Let me know what you think about that.

@JanKaul
Copy link
Owner

JanKaul commented Jul 30, 2025

Yeah, I think that would be best. Thanks again!

@gruuya gruuya force-pushed the equality-delete-scan-fix branch from ba5d824 to a48d48e Compare July 30, 2025 06:49
@JanKaul JanKaul merged commit bcd183f into JanKaul:main Jul 30, 2025
2 checks passed
@gruuya gruuya deleted the equality-delete-scan-fix branch July 30, 2025 07:41
JanKaul added a commit that referenced this pull request Jul 30, 2025
fix: skip adding another plan when no data file groups left during table scan
JanKaul added a commit that referenced this pull request Jul 30, 2025
fix: skip adding another plan when no data file groups left during table scan
JanKaul added a commit that referenced this pull request Jul 30, 2025
fix: skip adding another plan when no data file groups left during table scan
JanKaul added a commit that referenced this pull request Jul 30, 2025
fix: skip adding another plan when no data file groups left during table scan
JanKaul added a commit that referenced this pull request Jul 31, 2025
fix: skip adding another plan when no data file groups left during table scan
JanKaul added a commit that referenced this pull request Jul 31, 2025
fix: skip adding another plan when no data file groups left during table scan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

table_scan execution panic for tables with matching data and delete files

2 participants