Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor readers #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor readers #64

wants to merge 2 commits into from

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Nov 18, 2024

Refactor readers to factorize code and simplify operations logic

Comment on lines +140 to +143
let manifest_location = format!(
"{}/metadata/{}-m{}.avro",
self.table_metadata.location, self.snapshot_uuid, self.manifest_index
);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error is coming from here. The manifest_index should be different for every manifest_group. It's overwriting the previous files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, looks like I was forgetting to update manifest_index. It should be easy to add an extra test to also catch this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants