Refactor readers #64
Open
Refactor readers #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
force-pushed
the
refacto-readers
branch
from
81c690a to
7b3e44b
Compare
JanKaul
reviewed
Nov 24, 2024
Comment on lines
+140
to
+143
| let manifest_location = format!( | ||
| "{}/metadata/{}-m{}.avro", | ||
| self.table_metadata.location, self.snapshot_uuid, self.manifest_index | ||
| ); |
There was a problem hiding this comment.
I think the error is coming from here. The manifest_index should be different for every manifest_group. It's overwriting the previous files.
There was a problem hiding this comment.
Ah yes, looks like I was forgetting to update manifest_index. It should be easy to add an extra test to also catch this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor readers to factorize code and simplify operations logic