chore: update to clap v4 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Friendly ping, @JanLikar :) |
JanLikar
approved these changes
Jan 23, 2023
|
Sorry for neglecting this, life got in the way. Looks good, as always. Thanks for contributing! |
|
@MarcoIeni I published the new versions now. As for release-plz... I would be happy to have a Github Actions workflow for publishing the crates! But I'd like a manually-triggered workflow, because publishing a new version whenever there's a push to master doesn't sound like a good idea to me. That could get messy |
Release-plz opens a "release pr" when there are new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated to clap v4. At the beginning I tried to update by keeping the builder pattern here. However, I got weird errors (quiet and verbose args that conflict). So I decided to use the easier "derive" pattern. I hope it's fine. The code looks much cleaner. 👍
OT: can you release this package with the latest changes? I know releasing is boring. If you want, I can integrate release-plz in this repo to automate the release process :)