Skip to content

Commit

Permalink
deps,win: set MSVS .obj folders in gyp for V8
Browse files Browse the repository at this point in the history
Building on Windows fails depending on the result from sharding the
deps/v8/src/v8.gyp:v8_base target. If two source files with the same
name are in the same shard, their output object file path would
conflict with one another. One example of this conflict is v8_base's
runtime/runtime.cc and the V8 inspector's protocol/Runtime.cpp that
is generated at build time, for which the files runtime.obj and
Runtime.obj would be created, but msvs overwrites one of them with
the other.

Dividing the .obj output path by the original source's extension
prevents this overwrite.

Fixes: nodejs/v8#4
  • Loading branch information
jaimecbernardo authored and joaocgreis committed Jun 28, 2017
1 parent ed12ea3 commit 7d26f49
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions deps/v8/src/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1742,6 +1742,13 @@
# limit. This breaks it into multiple pieces to avoid the limit.
# See http://crbug.com/485155.
'msvs_shard': 4,
# This will prevent V8's .cc files conflicting with the inspector's
# .cpp files in the same shard.
'msvs_settings': {
'VCCLCompilerTool': {
'ObjectFile':'$(IntDir)/%(Extension)/',
},
},
}],
['component=="shared_library"', {
'defines': [
Expand Down

0 comments on commit 7d26f49

Please sign in to comment.