Skip to content

Commit

Permalink
build: update manifest to include Windows 10
Browse files Browse the repository at this point in the history
Windows 10 wasn't listed in the executable manifest.
This caused problems with trying to detect Windows 10
via `os.release()`.

PR-URL: nodejs#2332
Reviewed-By: Roman Reiss <me@silverwind.io>
  • Loading branch information
LPGhatguy authored and silverwind committed Aug 9, 2015
1 parent 7d14dd9 commit b0dd3bf
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/res/node.exe.extra.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
<application>
<!-- Windows 10 -->
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
<!-- Windows 8.1 -->
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
<!-- Windows 8 -->
Expand Down

0 comments on commit b0dd3bf

Please sign in to comment.