Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typescript type definitions #12

Merged
merged 7 commits into from
Aug 26, 2019
Merged

add typescript type definitions #12

merged 7 commits into from
Aug 26, 2019

Conversation

is343
Copy link
Contributor

@is343 is343 commented Jul 14, 2019

No description provided.

is343 and others added 4 commits July 14, 2019 14:58
@is343
add typescript type definitions
c33fd8f
@is343
add optional context to listener
2584369
@is343
fix callback for listener
41fcd36
@is343
add removeListener
cf4fe0d 
I didn't originally add this because it wasn't listed in the docs. However, I noticed it used in the example repo, and went to check that it did in fact exist.
@jaimecbernardo
Copy link
Member

Hi @is343 ,
Thank you for this on-going contribution. :)
Please add me as a reviewer once the changes are done, with some instructions on how to test it.

@is343
Copy link
Contributor Author

is343 commented Jul 15, 2019

I used one of the samples from the nodejs-mobile-samples repo and added typescript as a dev dependency and made an App.tsx file from the App.js here.

You can just npm install to get typescript and my branch's nodejs-mobile-react-native ready, then just check out App.tsx to see the typings.

@is343
Copy link
Contributor Author

is343 commented Jul 15, 2019

@jaimecbernardo I don't think I have the permissions necessary to add reviewers, but I am ready for you to check this PR out.

Let me know if you need me to change anything!

@jaimecbernardo jaimecbernardo self-requested a review July 18, 2019 10:40
@jaimecbernardo
Copy link
Member

Hi @is343,
Thank you for the contribution.
I've added myself as a reviewer and will give some feedback once I've been able to give it a test, but it looks good so far.

jaimecbernardo
jaimecbernardo approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working as expected. Thank you for the contribution!

@jaimecbernardo jaimecbernardo merged commit dd7c67a into JaneaSystems:unstable Aug 26, 2019
softdevjs7 added a commit to softdevjs7/nodejs-mobile-react-native that referenced this pull request Sep 30, 2022
@softdevjs7
plugin: add typescript type definitions
4d8f6e1 
Adds TypeScript type definitions to the plugin.

PR-URL: JaneaSystems/nodejs-mobile-react-native#12
Reviewed-By: Jaime Bernardo <jaime@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimecbernardo jaimecbernardo jaimecbernardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@is343 @jaimecbernardo