Skip to content

Overflow bugfix #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Overflow bugfix #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/jquery.easytabs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,8 @@
visibleHeight,
heightDifference,
showPanel,
hash = window.location.hash.match(/^[^\?]*/)[0];
hash = window.location.hash.match(/^[^\?]*/)[0],
overflowSetting;

if (settings.animate) {
targetHeight = getHeightForHidden($targetPanel);
Expand All @@ -529,10 +530,13 @@
// Gracefully animate between panels of differing heights, start height change animation *after* panel change if panel needs to contract,
// so that there is no chance of making the visible panel overflowing the height of the target panel
if (settings.animate && settings.transitionIn == 'fadeIn') {
if (heightDifference < 0)
$panelContainer.animate({
height: $panelContainer.height() + heightDifference
}, transitions.halfSpeed ).css({ 'min-height': '' });
if (heightDifference < 0) {
overflowSetting = $panelContainer.css('overflow');
$panelContainer.animate({
height: $panelContainer.height() + heightDifference
}, transitions.halfSpeed ).css({ 'min-height': '' });
$panelContainer.css('overflow', overflowSetting);
}
}

if ( settings.updateHash && ! skipUpdateToHash ) {
Expand Down Expand Up @@ -566,9 +570,11 @@
// so that there is no chance of making the target panel overflowing the height of the visible panel
if( settings.animate && settings.transitionOut == 'fadeOut' ) {
if( heightDifference > 0 ) {
overflowSetting = $panelContainer.css('overflow');
$panelContainer.animate({
height: ( $panelContainer.height() + heightDifference )
}, transitions.halfSpeed );
$panelContainer.css('overflow', overflowSetting);
} else {
// Prevent height jumping before height transition is triggered at midTransition
$panelContainer.css({ 'min-height': $panelContainer.height() });
Expand Down