fix: avoid NPE when configuration is missing #2857 (#2863)

JanssenProject · Nov 8, 2022 · 007b3ec · 007b3ec
1 parent 4cd9f57
commit 007b3ec
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/agama/engine/src/main/java/io/jans/agama/engine/service/AppInitializer.java b/agama/engine/src/main/java/io/jans/agama/engine/service/AppInitializer.java
@@ -9,13 +9,8 @@
 import jakarta.enterprise.event.Observes;
 import jakarta.inject.Inject;
 
-import org.slf4j.Logger;
-
 @ApplicationScoped
 public class AppInitializer {
-
-    @Inject
-    private Logger logger;
 
     @Inject
     private Transpilation trTimer;
@@ -25,11 +20,10 @@ public class AppInitializer {
 
     public void run(@Observes @ApplicationInitialized(ApplicationScoped.class) 
             ApplicationInitializedEvent event) {
-
-        logger.info("Initializing Agama services");
+
         trTimer.initTimer();
         fcleaner.initTimer();
 
     }
-    
+
 }
diff --git a/agama/engine/src/main/java/io/jans/agama/engine/service/ServicesFactory.java b/agama/engine/src/main/java/io/jans/agama/engine/service/ServicesFactory.java
@@ -43,9 +43,16 @@ public EngineConfig engineConfigInstance() {
     public void updateConfiguration(@Observes @ConfigurationUpdate AppConfiguration appConfiguration) {
 
         try {
-            logger.info("Refreshing Agama configuration...");
-            BeanUtils.copyProperties(econfig, appConfiguration.getAgamaConfiguration());
-            serializerFactory.refresh();
+            EngineConfig newConfig = appConfiguration.getAgamaConfiguration();
+
+            if (newConfig == null) {
+                logger.info("Agama will not be available in this deployment");
+
+            } else {
+                logger.info("Refreshing Agama configuration...");
+                BeanUtils.copyProperties(econfig, newConfig);
+                serializerFactory.refresh();
+            }
         } catch (Exception e) {
             logger.error(e.getMessage(), e);
         }