feat: add POST /rolePermissionsMapping for adding new rolePermissions…

…Mapping entry #144
JanssenProject · Jan 6, 2022 · 149aeb1 · 149aeb1
1 parent 932a45b
commit 149aeb1
Showing 1 changed file with 0 additions and 7 deletions.
diff --git a/...ui-plugin/src/main/java/io/jans/ca/plugin/adminui/service/user/UserManagementService.java b/...ui-plugin/src/main/java/io/jans/ca/plugin/adminui/service/user/UserManagementService.java
@@ -251,7 +251,6 @@ public List<RolePermissionMapping> addPermissionsToRole(RolePermissionMapping ro
             entryManager.merge(adminConf);
             return adminConf.getDynamic().getRolePermissionMapping();
         } catch (ApplicationException e) {
-            log.error(e.getMessage());
             throw e;
         } catch (Exception e) {
             log.error(ErrorResponse.ERROR_IN_MAPPING_ROLE_PERMISSION.getDescription(), e);
@@ -287,14 +286,9 @@ public List<RolePermissionMapping> mapPermissionsToRole(RolePermissionMapping ro
             }
 
             Optional<RolePermissionMapping> rolePermissionMappingOptional = roleScopeMappingList.stream().findFirst();
-            List<String> mappedPermissions = Lists.newArrayList();
-            if (rolePermissionMappingOptional.isPresent()) {
-                mappedPermissions = rolePermissionMappingOptional.get().getPermissions();
-            }
 
             //remove duplicate permissions
             Set<String> scopesSet = new LinkedHashSet<>(rolePermissionMappingArg.getPermissions());
-            //scopesSet.addAll(rolePermissionMappingArg.getPermissions());
             List<String> combinedScopes = new ArrayList<>(scopesSet);
 
             if (adminConf.getDynamic().getRolePermissionMapping()
@@ -311,7 +305,6 @@ public List<RolePermissionMapping> mapPermissionsToRole(RolePermissionMapping ro
             entryManager.merge(adminConf);
             return adminConf.getDynamic().getRolePermissionMapping();
         } catch (ApplicationException e) {
-            log.error(e.getMessage());
             throw e;
         } catch (Exception e) {
             log.error(ErrorResponse.ERROR_IN_MAPPING_ROLE_PERMISSION.getDescription(), e);