Skip to content

Commit

Permalink
fix(pycloudlib): searching values from spanner returns empty set (#2833)
Browse files Browse the repository at this point in the history
* fix(pycloudlib): searching values from spanner returns empty set

* chore(jans-pycloudlib): updated build (#2834)

Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>

Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>

Signed-off-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
Co-authored-by: mo-auto <54212639+mo-auto@users.noreply.github.com>
Co-authored-by: Mohammad Abudayyeh <47318409+moabu@users.noreply.github.com>
  • Loading branch information
3 people authored Nov 2, 2022
1 parent ed8fa84 commit 861a065
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion docker-jans-auth-server/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pinned to py3-grpcio version to avoid failure on native extension build
grpcio==1.41.0
libcst<0.4
git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
2 changes: 1 addition & 1 deletion docker-jans-certmanager/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
grpcio==1.41.0
click==6.7
libcst<0.4
git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
2 changes: 1 addition & 1 deletion docker-jans-config-api/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
grpcio==1.41.0
libcst<0.4
ruamel.yaml==0.16.10
git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
2 changes: 1 addition & 1 deletion docker-jans-configurator/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ click==6.7
marshmallow==3.10.0
fqdn==1.4.0
libcst<0.4
git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
2 changes: 1 addition & 1 deletion docker-jans-fido2/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pinned to py3-grpcio version to avoid failure on native extension build
grpcio==1.41.0
libcst<0.4
git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
2 changes: 1 addition & 1 deletion docker-jans-persistence-loader/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
grpcio==1.41.0
libcst<0.4
ruamel.yaml==0.16.10
git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
2 changes: 1 addition & 1 deletion docker-jans-scim/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
grpcio==1.41.0
libcst<0.4
ruamel.yaml==0.16.10
git+https://github.com/JanssenProject/jans@9da7ae2533918d533caa8caca7cfc34656a0de62#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
git+https://github.com/JanssenProject/jans@4063981f124d9111c41357d868183295b55b6d86#egg=jans-pycloudlib&subdirectory=jans-pycloudlib
2 changes: 0 additions & 2 deletions jans-pycloudlib/jans/pycloudlib/persistence/spanner.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,6 @@ def search(self, table_name: str, column_names: _t.Union[list[str], None] = None
if not column_names:
# TODO: faster lookup on column names
col_names = list(self.get_table_mapping().get(table_name, {}).keys())
else:
col_names = []

with self.database.snapshot() as snapshot: # type: ignore
result = snapshot.read(
Expand Down

0 comments on commit 861a065

Please sign in to comment.