-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auth Server should Support Client Registration Language Metadata #1057
Comments
The Client metadata values: client_name (displayName), logo_uri (jansLogoURI), client_uri (jansClntURI), policy_uri (jansPolicyURI), and tos_uri (jansTosURI) now stores a JSON with values for multiple languages and scripts. For example: MySQL, Couchbase, Spanner, etc.client_name (displayName)logo_uri (jansLogoURI)client_uri (jansClntURI)policy_uri (jansPolicyURI)tos_uri (jansTosURI)LDAPLDAP has support for Language Tags |
This is an interesting feature. Let's make sure it gets listed in the internationalization section of the docs. |
This #1482 problem related to this ticket. LanguageTag should support read from DB and search in filters. Why ORM layer should know how to handle specialized LanguageTag annotation? ORM has generic solution to work with JSON objects. Instead of this:
We can use:
|
I saw your implementation for LDAP. In this case ORM based on server functionality. But in all other cases there is no in DB special support for language tags, etc. LDAP is losing it's positions in CE. I think in this case there is no major point to implement something special for it. For me @LanguageTag == @JsonObject . In both cases we store data in JSON. @JsonObject we already support in setup in all projects, etc.. For me is better to use one @JsonObject to keep ORM layer sampler for support. |
If you need to implement special behavior you can use 2 or more tags. Sample:
|
Looks like there are many tests that are failing because of this issue, do we have some fix coming? |
@qbert2k where are with this issue? It still effects integration tests and keeps as blind with server functionality overall. Can you take it as priority? |
@yuriyz I will contact you by chat with more details. |
@qbert2k does tests work ok for you ? It does not on jenkins as you can see. |
great! |
Section 2.1 of OpenID Client Reg states:
Human-readable Client Metadata values and Client Metadata values that reference human-readable values MAY be
represented in multiple languages and scripts. For example, values such as client_name, tos_uri, policy_uri, logo_uri, and
client_uri might have multiple locale-specific values in some Client registrations.
To specify the languages and scripts, BCP47
[RFC5646] language tags are added to Client Metadata member names, delimited by a # character. The same syntax is used
for representing languages and scripts for Client Metadata as is used for Claims, as described in Section 5.2 (Claims
Languages and Scripts) of [OpenID Connect Core 1.0](https://openid.net/specs/openid-connect-registration-
1_0.html#OpenID.Core) [OpenID.Core].
If such a human-readable field is sent without a language tag, parties using it MUST NOT make any assumptions about the
language, character set, or script of the string value, and the string value MUST be used as-is wherever it is presented in a
user interface. To facilitate interoperability, it is RECOMMENDED that any human-readable fields sent without language tags
contain values suitable for display on a wide variety of systems.
client_name
andclient_uri
.The text was updated successfully, but these errors were encountered: