Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (jans-config-api) : some url fields have object value for oidc clients GET response #1765

Closed
duttarnab opened this issue Jul 12, 2022 · 6 comments
Assignees
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone

Comments

@duttarnab
Copy link
Contributor

duttarnab commented Jul 12, 2022

Describe the bug
For /jans-config-api/api/v1/openid/clients GET following url fields have object value.

  • clientUri
  • logoUri
  • policyUri
  • tosUri

Expected behavior
The string values are expected for url fields.

@duttarnab duttarnab added kind-bug Issue or PR is a bug in existing functionality comp-jans-config-api Component affected by issue or PR labels Jul 12, 2022
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Jul 12, 2022
@duttarnab duttarnab changed the title feat (jans-config-api) : some url fields have object value for oidc clients GET response fix (jans-config-api) : some url fields have object value for oidc clients GET response Jul 12, 2022
@duttarnab duttarnab removed the kind-feature Issue or PR is a new feature request label Jul 12, 2022
@yuriyz
Copy link
Contributor

yuriyz commented Jul 12, 2022

These fields are not strings anymore because it was moved to LocalizedString by Javier. It can't be represented with just string.

@duttarnab check this ticket for details #1057

public class LocalizedString implements Serializable {

@pujavs
Copy link
Contributor

pujavs commented Jul 13, 2022

LocalizedString changes under discussion with @yuriyz @yurem and @qbert2k

@moabu moabu added this to the 1.0.2 milestone Jul 14, 2022
@yuriyz
Copy link
Contributor

yuriyz commented Jul 14, 2022

I guess at the end we agree that simplification is needed as proposed by @yurem
image

@pujavs
Copy link
Contributor

pujavs commented Jul 18, 2022

@qbert2k, request you to please confirm once the LocalizedString changes as suggested by @yurem are implemented so that we can verify and test the impacted functionality.

@pujavs
Copy link
Contributor

pujavs commented Nov 9, 2022

@duttarnab, @qbert2k seems to have fixed this. I tested locally and getting these values as string now. request you to please verify.
image

@moabu moabu modified the milestones: 1.0.4, 1.0.5 Nov 14, 2022
@moabu moabu modified the milestones: 1.0.5, 1.0.6 Dec 1, 2022
@pujavs
Copy link
Contributor

pujavs commented Dec 20, 2022

Fixed see #2946

@pujavs pujavs closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

No branches or pull requests

6 participants