Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Permisson Page #1480

Closed
devrimyatar opened this issue May 31, 2022 · 5 comments
Closed

Request Permisson Page #1480

devrimyatar opened this issue May 31, 2022 · 5 comments
Assignees
@jmunozherbas
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.7

Comments

@devrimyatar
Copy link
Contributor

Describe the bug
In request permission page:
1 ) image is missing
2) requester is missing, instead {} is requesting permission to do the following is displayed

To Reproduce
Steps to reproduce the behavior:

  1. Install Jans server
  2. Start CLI
  3. Request an item
  4. Go device authorization page, enter code
  5. Login as admin
  6. You will see Request Permisson page as follows

Screenshot_2022-05-31_14-41-03
@devrimyatar devrimyatar assigned moabu and yuriyz and unassigned moabu May 31, 2022
@yuriyz yuriyz assigned qbert2k and unassigned yuriyz May 31, 2022
@yuriyz yuriyz added comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels May 31, 2022
@devrimyatar
Copy link
Contributor Author

In 1.0.1, it changed slightly
Screenshot_2022-06-01_16-18-18

@moabu moabu added this to the 1.0.1 milestone Jun 15, 2022
@moabu moabu modified the milestones: 1.0.1, 1.0.2 Jul 8, 2022
@moabu moabu assigned jmunozherbas and unassigned qbert2k Jul 8, 2022
@manojs1978
Copy link
Contributor

image
image is still not loading

@jmunozherbas
Copy link
Contributor

I found this problem is due to LocalizedString implementation.
2022-07-14_02-50
2022-07-14_02-55

Who could help me to understand the way show this data type correctly?

I have tested a way to show:
5cdc834

@yuriyz
Copy link
Contributor

yuriyz commented Jul 14, 2022

After simplification as described by @yurem on which I guess all agreed we wouldn't need workaround.

See #1765 (comment)

@moabu moabu modified the milestones: 1.0.2, 1.0.3 Aug 30, 2022
@moabu moabu modified the milestones: 1.0.3, 1.0.4 Nov 3, 2022
@moabu moabu modified the milestones: 1.0.4, 1.0.5 Nov 14, 2022
@moabu moabu modified the milestones: 1.0.5, 1.0.6 Dec 1, 2022
@moabu moabu modified the milestones: 1.0.6, 1.0.7 Jan 9, 2023
@devrimyatar
Copy link
Contributor Author

Fixed
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmunozherbas jmunozherbas

Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.7
Development

No branches or pull requests
6 participants
@yuriyz @qbert2k @manojs1978 @devrimyatar @jmunozherbas @moabu