Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CLI client for automated testing #1283

Closed
devrimyatar opened this issue May 4, 2022 · 1 comment · Fixed by #1285
Closed

Test CLI client for automated testing #1283

devrimyatar opened this issue May 4, 2022 · 1 comment · Fixed by #1285
Assignees
@devrimyatar
Labels
comp-jans-cli-tui Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR enhancement

Comments

@devrimyatar
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently CLI uses client that requires device authorization and not suitable for automated testing. We need a client that does not require user intervention.

Describe the solution you'd like
Add an option --cli-test-client to setup.py so that it is created at install time, and modify CLI so that it uses test client if exists.
@devrimyatar devrimyatar added comp-jans-cli-tui Component affected by issue or PR enhancement comp-jans-linux-setup Component affected by issue or PR labels May 4, 2022
@devrimyatar devrimyatar self-assigned this May 4, 2022
devrimyatar added a commit that referenced this issue May 4, 2022
@devrimyatar
feat: jans-cli use test client (ref: #1283)
4bcd6da
@devrimyatar devrimyatar mentioned this issue May 4, 2022
Merged
devrimyatar added a commit that referenced this issue May 4, 2022
@devrimyatar
feat: jans-linux-setup add option --cli-test-client (ref: #1283)
7b8c29c
yuriyz pushed a commit that referenced this issue May 4, 2022
@devrimyatar
feat: jans-cli use test client (ref: #1283) (#1285)
6320af7 
* feat: jans-cli use test client (ref: #1283)

* feat: jans-linux-setup add option --cli-test-client (ref: #1283)

* feat: jans-cli code smells

* feat: jans-cli use test client only if arg -use-test-client provided
@devrimyatar
Copy link
Contributor Author

Implemented

@moabu moabu linked a pull request May 5, 2022 that will close this issue
feat: jans-cli use test client (ref: #1283) #1285
Merged
This was referenced May 18, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

Labels
comp-jans-cli-tui Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: jans-cli use test client (ref: #1283) JanssenProject/jans
1 participant
@devrimyatar