Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: jans-cli group common items in menu (ref: #892) #1306

Merged
merged 2 commits into from
May 6, 2022
Merged

feat: jans-cli group common items in menu (ref: #892) #1306

merged 2 commits into from
May 6, 2022

Conversation

devrimyatar
Copy link
Contributor

As discussed in #892, common items are grouped and placed in submenu:

submenu

@devrimyatar devrimyatar added comp-jans-cli-tui Component affected by issue or PR kind-feature Issue or PR is a new feature request labels May 6, 2022
@devrimyatar devrimyatar requested review from yuriyz and pujavs May 6, 2022 18:57
@devrimyatar devrimyatar marked this pull request as draft May 6, 2022 18:57
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2022

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@devrimyatar devrimyatar marked this pull request as ready for review May 6, 2022 19:09
@yuriyz yuriyz merged commit 819f8f7 into main May 6, 2022
@yuriyz yuriyz deleted the jans-cli-submenu branch May 6, 2022 20:36
This was referenced May 18, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@pujavs pujavs Awaiting requested review from pujavs

Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devrimyatar @yuriyz