Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jans-cli: suggestion for better usability #892

Closed
pujavs opened this issue Feb 24, 2022 · 7 comments
Closed

jans-cli: suggestion for better usability #892

pujavs opened this issue Feb 24, 2022 · 7 comments
Assignees
@devrimyatar
Milestone
1.0.13

Comments

@pujavs
Copy link
Contributor

pujavs commented Feb 24, 2022

Attached are the better user experience.
Jans-Cli-Feedback.pdf

Request you to please review and let me know if any change in config-api swagger spec to support the suggestion.
@devrimyatar
Copy link
Contributor

Suggestions are good, but some of them is not possible with simple input. Making these changes won't be sufficient.
At the beginning, config-cli was aimed something like dsconfig command. I propose to use UI. urwid (https://github.com/urwid/urwid) seems a good choice.

@nynymike
Copy link
Contributor

nynymike commented Mar 1, 2022

It has to be CLI only. A lot of people will be dropping in from a docker shell. Let's go through each issue that was raised by @pujavs in more detail.

@manojs1978
Copy link
Contributor

manojs1978 commented Mar 2, 2022 •
edited by nynymike
Loading

We need add mandatory fields on "create new openid client" which need to be populated while creating new openID client.
eg: redirect_uri

@devrimyatar
Copy link
Contributor

we need add mendatory fields on "create new openid client" which need to be populated while creating new openID client. ex: client secret

This is not inside CLI, it comes from https://github.com/JanssenProject/jans/blob/main/jans-config-api/docs/jans-config-api-swagger.yaml#L5088-L5108

@devrimyatar
Copy link
Contributor

It has to be CLI only. A lot of people will be dropping in from a docker shell. Let's go through each issue that was raised by @pujavs in more detail.

By UI I meant to say TUI that is similar to we use for Gluu Setup:

image

So it can run on docker shell.

devrimyatar added a commit that referenced this issue Mar 2, 2022
@devrimyatar
feat: jans-cli display accepted values before input (ref: #892)
ae050ae
devrimyatar added a commit that referenced this issue Mar 2, 2022
@devrimyatar
feat: jans-cli remove warning (ref: #892)
c5d3119
@nynymike
Copy link
Contributor

nynymike commented Mar 2, 2022

As long as it runs in the shell, it's ok.

yuriyz pushed a commit that referenced this issue Mar 4, 2022
@devrimyatar
fix(jans-linux-setup): require python3-distutils for deb clones (#967)
9a76f23 
* feat: jans-cli display accepted values before input (ref: #892)

* feat: jans-cli remove warning (ref: #892)

* fix: user ascii character for dash

* fix: jans-cli change buildname to config-cli.pyz

* fix: jans-cli develop build command 'pip3 install -e .'

* feat: jans-cli hide endpoints if plugin is not available

* feat: jans-cli auto-fill

* fix: jans-linux-setup require python3-distutils for deb
devrimyatar added a commit that referenced this issue May 6, 2022
@devrimyatar
feat: jans-cli group common items in menu (ref: #892)
f09d0a1
@devrimyatar devrimyatar mentioned this issue May 6, 2022
Merged
yuriyz pushed a commit that referenced this issue May 6, 2022
@devrimyatar
feat: jans-cli group common items in menu (ref: #892) (#1306)
819f8f7 
* feat: jans-cli group common items in menu (ref: #892)

* feat: jans-cli code smell
@devrimyatar devrimyatar mentioned this issue May 9, 2022
Merged
This was referenced May 18, 2022
Merged
Merged
@moabu moabu added this to the 1.0.1 milestone Jun 15, 2022
@moabu moabu modified the milestones: 1.0.1, 1.0.2 Jul 8, 2022
@moabu moabu modified the milestones: 1.0.2, 1.0.3 Aug 30, 2022
@moabu moabu modified the milestones: 1.0.3, 1.0.4 Nov 3, 2022
@moabu moabu modified the milestones: 1.0.4, 1.0.5 Nov 14, 2022
@moabu moabu modified the milestones: 1.0.5, 1.0.6 Dec 1, 2022
@moabu moabu modified the milestones: 1.0.6, 1.0.7 Jan 9, 2023
@moabu moabu removed this from the 1.0.7 milestone Mar 1, 2023
@moabu moabu modified the milestones: 1.0.8, 1.0.9 Mar 1, 2023
@moabu moabu modified the milestones: 1.0.9, 1.0.10 Mar 9, 2023
@moabu moabu modified the milestones: 1.0.10, 1.0.11 Mar 16, 2023
@moabu moabu modified the milestones: 1.0.11, 1.0.12 Apr 5, 2023
@moabu moabu modified the milestones: 1.0.12, 1.0.13 Apr 18, 2023
@devrimyatar
Copy link
Contributor

IM was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

Labels
None yet
Projects
None yet
Milestone
1.0.13
Development

No branches or pull requests
5 participants
@nynymike @manojs1978 @devrimyatar @pujavs @moabu