Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help message showing possible prompt responses at jans-cli prompt needs to be fixed #1352

Closed
2 tasks
ossdhaval opened this issue May 17, 2022 · 1 comment
Closed
2 tasks

Help message showing possible prompt responses at jans-cli prompt needs to be fixed #1352

ossdhaval opened this issue May 17, 2022 · 1 comment
Assignees
@devrimyatar
Labels
comp-jans-cli-tui Component affected by issue or PR effort-2 Relative effort required for completion of issue or PR kind-bug Issue or PR is a bug in existing functionality priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system

Comments

@ossdhaval
Copy link
Contributor

Describe the bug

Case 1:

image

Case 2

image

In above images, help message in grey color has two issues.

  1. Format: missing comma after second and third option
  2. Missing options: As can be seen in the orange color help message, there are more options, like w for case 1 and y and n for case 2, that are not shown in the grey color help message. All possible options should be listed as part of grey message.

To Reproduce
Steps to reproduce the behavior (screenshot 1):

  1. Install Janssen server
  2. Invoke config-cli from command line
  3. select option for health-check (for case 1) and select option OAuth - OpenID Connect - Clients (for case 2)

Expected behavior

  • Formatting should be fixed
  • All possible prompts response options should be shown in help messages
@ossdhaval ossdhaval added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR effort-2 Relative effort required for completion of issue or PR priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system labels May 17, 2022
devrimyatar added a commit that referenced this issue May 31, 2022
@devrimyatar
fix: jans-cli help message format and prompt values (ref: #1352)
f067a30
@devrimyatar devrimyatar mentioned this issue May 31, 2022
Merged
yuriyz pushed a commit that referenced this issue Jun 6, 2022
@devrimyatar
fix: jans-cli help message format and prompt values (ref: #1352) (#1478)
37a9181 
* fix: jans-cli help message format and prompt values (ref: #1352)

* fix: jans-cli hide menu items if plugin unavailable
@devrimyatar
Copy link
Contributor

Fixed

image

This was referenced Jul 6, 2022
Merged
Merged
This was referenced Aug 30, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devrimyatar devrimyatar

Labels
comp-jans-cli-tui Component affected by issue or PR effort-2 Relative effort required for completion of issue or PR kind-bug Issue or PR is a bug in existing functionality priority-4 Minor issue or PR is not relevant to core functions, or relates to the usability of system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ossdhaval @devrimyatar