-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jans-orm):sql localizedstring persistence SqlEntryManager #1475
Conversation
[orm] Kudos, SonarCloud Quality Gate passed! |
@yuriyz @jmunozherbas Why we need this method on ORM layer. It not works with DB. The better place for it is in reusable service layer. |
@jmunozherbas in PR description you added reference to #260 |
@qbert2k Can you share design related to Why we simply can't use?
|
Right, this particular PR comes out of what was done in LDAP entry manager for |
I mentioned Issue, because it was the origin of the change, but doesn't have a specific Issue. |
Description
SqlEntryManager: method to get LocalizedString values was modified similar to SqlLdapEntryManager
detected trying to persist sites with mysql DB.
Origin Issue
#260