Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-design oxd Connect part to work inside user-agent instead of as backchannel app. #260

Closed
duttarnab opened this issue Nov 26, 2020 · 5 comments
Closed

Re-design oxd Connect part to work inside user-agent instead of as backchannel app. #260

duttarnab opened this issue Nov 26, 2020 · 5 comments
Assignees
@jmunozherbas
Labels
comp-jans-client-api Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality needs-triage Issue or PR yet to be triaged. Add more labels or details that will help during triage review.

Comments

@duttarnab
Copy link
Contributor

Refer : GluuFederation/oxd#462
@duttarnab duttarnab self-assigned this Nov 26, 2020
@ossdhaval ossdhaval transferred this issue from another repository Jan 13, 2022
@ossdhaval ossdhaval added comp-jans-client-api Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality needs-triage Issue or PR yet to be triaged. Add more labels or details that will help during triage review. labels Jan 13, 2022
moabu pushed a commit that referenced this issue Jan 13, 2022
@yuriyz
Merge pull request #260 from JanssenProject/yuriyz_deps
1f48f93 
fix: removed saml profile
moabu pushed a commit that referenced this issue Jan 13, 2022
@yuriyz
Merge pull request #260 from JanssenProject/yuriyz_deps
421c4e7 
fix: removed saml profile
@yuriyz
Copy link
Contributor

yuriyz commented Mar 29, 2022

Latest dropwizard still sticks to jetty 9 (<jetty.version>9.4.45.v20220203</jetty.version>).
It can be right time to drop dropwizard and migrate to weld/resteasy and get it works exactly in same way as AS and config-api work.

https://github.com/dropwizard/dropwizard/blob/release/2.1.x/dropwizard-dependencies/pom.xml#L52

@nynymike
Copy link
Contributor

Is that a huge amount of work? What's the impact on deployment?

@yuriyz
Copy link
Contributor

yuriyz commented Mar 29, 2022

Yes, it is good amount of work. Also deployment scripts has to be corrected. Instead of standalone run it would be deployment of war to jetty (same story as with AS and jans-config-api).

@yuriyz yuriyz assigned jmunozherbas and unassigned duttarnab Mar 29, 2022
@yuriyz
Copy link
Contributor

yuriyz commented Mar 29, 2022

It has to be 2 steps process:

  1. move project to Weld/resteasy (dependencies aligned with jans-bom) with deployment update - jakarta based (see jans-jetty-upgrade)
  2. improve design of commands after 1) is done.

duttarnab added a commit that referenced this issue Apr 11, 2022
@duttarnab
feat: weld & resteasy migration of jans-client-api #260
c08819a
@jmunozherbas jmunozherbas mentioned this issue May 11, 2022
Merged
@jmunozherbas jmunozherbas linked a pull request May 11, 2022 that will close this issue
feat(jans-client-api): migration to Weld/Resteasy and Jetty 11 - Issue 260 #1319
Merged
@jmunozherbas jmunozherbas removed a link to a pull request May 11, 2022
feat(jans-client-api): migration to Weld/Resteasy and Jetty 11 - Issue 260 #1319
Merged
@jmunozherbas jmunozherbas mentioned this issue May 31, 2022
Merged
@yuriyz
Copy link
Contributor

yuriyz commented Jun 10, 2022

Done within #1319

@yuriyz yuriyz closed this as completed Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmunozherbas jmunozherbas

Labels
comp-jans-client-api Component affected by issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality needs-triage Issue or PR yet to be triaged. Add more labels or details that will help during triage review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ossdhaval @yuriyz @nynymike @duttarnab @jmunozherbas