Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(fido2): move configuration modules from jans-fido2-server to jans-fido2-model #2389

Closed
pujavs opened this issue Sep 15, 2022 · 0 comments · Fixed by #2838
Closed

chore(fido2): move configuration modules from jans-fido2-server to jans-fido2-model #2389

pujavs opened this issue Sep 15, 2022 · 0 comments · Fixed by #2838
Assignees
@yurem @maduvena
Labels
comp-jans-fido2 Component affected by issue or PR enhancement kind-dependencies Pull requests that update a dependency file
Milestone
1.0.3

Comments

@pujavs
Copy link
Contributor

pujavs commented Sep 15, 2022

Currently, the configuration is in the server module: jans-fido2-server -> https://github.com/JanssenProject/jans/tree/main/jans-fido2/model
This needs to be moved to jans-fido2-model so that other apps like jans-config-api can reuse instead of duplicate
@pujavs pujavs added comp-jans-fido2 Component affected by issue or PR enhancement labels Sep 15, 2022
@pujavs pujavs changed the title chore(fido2): move configuration modules to chore(fido2): move configuration modules from jans-fido2-server to jans-fido2-model Sep 15, 2022
@mo-auto mo-auto added the kind-dependencies Pull requests that update a dependency file label Sep 15, 2022
@moabu moabu added this to the 1.0.3 milestone Sep 29, 2022
@yurem yurem assigned yurem and maduvena and unassigned yuremm Oct 28, 2022
maduvena added a commit that referenced this issue Nov 2, 2022
@maduvena
chore: #2389
1bd59f4
@maduvena maduvena mentioned this issue Nov 2, 2022
Merged
yurem pushed a commit that referenced this issue Nov 2, 2022
@maduvena
chore: Issue 2389 (#2838)
7fc6adb 
* fix: #2825

* chore: #2389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurem yurem

@maduvena maduvena

Labels
comp-jans-fido2 Component affected by issue or PR enhancement kind-dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

chore: Issue 2389 JanssenProject/jans
6 participants
@yurem @maduvena @pujavs @moabu @mo-auto @yuremm