Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-config-api): incorrect https status for GET requests #2689

Closed
moabu opened this issue Oct 21, 2022 · 4 comments · Fixed by #2697
Closed

fix(jans-config-api): incorrect https status for GET requests #2689

moabu opened this issue Oct 21, 2022 · 4 comments · Fixed by #2697
Assignees
@pujavs
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.4

Comments

@moabu
Copy link
Member

moabu commented Oct 21, 2022

When requesting any AdminUI entities that do not exist, the expected behavior would be to get a 404 response from the server. However, currently I'm getting either a 400 bad request (for role and permission) or 500 server error (for rolePermissionMapping)
@moabu moabu self-assigned this Oct 21, 2022
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Oct 21, 2022
@pujavs pujavs mentioned this issue Oct 21, 2022
Merged
5 tasks
@pujavs
Copy link
Contributor

pujavs commented Oct 21, 2022

Fixed via PR 2697
Note correct URL:

  • /jans-config-api/admin-ui/adminUIRoles
  • /jans-config-api/admin-ui/adminUIPermissions
  • jans-config-api/admin-ui/adminUIRolePermissionsMapping

Testing:

  • /jans-config-api/admin-ui/adminUIRoles
    image

  • /jans-config-api/admin-ui/adminUIPermissions
    image

  • jans-config-api/admin-ui/adminUIRolePermissionsMapping
    image

@moabu
Copy link
Member Author

moabu commented Oct 28, 2022

@pujavs

CRUD operations all work correctly. However, the response you get when trying to GET an entity that actually doesn't exist. So the proper response code should be 404, instead I get 400 or 500.

@moabu moabu reopened this Oct 28, 2022
@moabu moabu assigned pujavs and unassigned moabu Oct 28, 2022
@moabu moabu added this to the 1.0.4 milestone Nov 3, 2022
@pujavs
Copy link
Contributor

pujavs commented Nov 3, 2022

Fixed
1.adminUIRoles
-Before Fix:
image
-After Fix:
image

2.adminUIPermissions
-Before Fix:
image
-After Fix:
image

3.adminUIRolePermissionsMapping
-Before Fix:
image
-After Fix:
image

@pujavs pujavs mentioned this issue Nov 3, 2022
Merged
5 tasks
@pujavs
Copy link
Contributor

pujavs commented Nov 7, 2022

Fixed via 2854

@pujavs pujavs closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pujavs pujavs

Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.4
Development

Successfully merging a pull request may close this issue.

fix(config-api): swagger fixes for missing scope and admin-ui paths JanssenProject/jans
3 participants
@pujavs @moabu @mo-auto