Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config-api): swagger fixes for missing scope and admin-ui paths #2697

Merged
merged 2 commits into from
Oct 21, 2022
Merged

fix(config-api): swagger fixes for missing scope and admin-ui paths #2697

merged 2 commits into from
Oct 21, 2022

Conversation

pujavs
Copy link
Contributor

@pujavs pujavs commented Oct 21, 2022 •
edited
Loading

Prepare

Description

Fixed swagger metadata and spec for missing scopes, removed redundant scopes and incorrect https status for GET requests

Target issue

closes #2689

Implementation Details

Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

@pujavs pujavs requested a review from yuriyz as a code owner October 21, 2022 17:22
@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Oct 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

[agama parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2022

[jans-config-api-parent] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pujavs pujavs mentioned this pull request Oct 21, 2022
Closed
@yuriyz yuriyz merged commit 6dcbff3 into main Oct 21, 2022
@yuriyz yuriyz deleted the jans-config-fixes branch October 21, 2022 20:40
@mo-auto mo-auto mentioned this pull request Nov 1, 2022
Merged
@mo-auto3 mo-auto3 mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

Assignees
No one assigned
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-config-api): incorrect https status for GET requests
3 participants
@pujavs @yuriyz @mo-auto