Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-config-api): problems with handling custom attributes #2752

Closed
moabu opened this issue Oct 28, 2022 · 8 comments
Closed

fix(jans-config-api): problems with handling custom attributes #2752

moabu opened this issue Oct 28, 2022 · 8 comments
Assignees
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@moabu
Copy link
Member

moabu commented Oct 28, 2022

Custom attributes currently cannot be handled properly, as they can have any value type (string, number, boolean, or an array thereof). Since most upstream clients can only support fixed primitive types, the type of an attribute must be well defined.

@mo-auto mo-auto added comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Oct 28, 2022
@pujavs
Copy link
Contributor

pujavs commented Oct 31, 2022

@yurem, request you to please suggest how to handle this request.

@moabu moabu added this to the 1.0.4 milestone Nov 3, 2022
@moabu moabu modified the milestones: 1.0.4, 1.0.5 Nov 14, 2022
@yurem
Copy link
Contributor

yurem commented Nov 17, 2022

@pujavs Is this issue related to LDAP ORM only?

@yurem
Copy link
Contributor

yurem commented Nov 17, 2022

Here is result with LDAP ORM after update:
изображение

Now LDAP ORM uses schema to determine if attribute has integer/boolean/date type to convert value to corresponding java data type from string.

@moabu
Copy link
Member Author

moabu commented Nov 17, 2022

@yurem it was a general observation. I was using MySQL when I was investigating. We generally need the type of attributes to be well defined

@yurem
Copy link
Contributor

yurem commented Nov 18, 2022

Can you provide real example to reproduce this issue?

@yurem
Copy link
Contributor

yurem commented Nov 18, 2022

Same example which I run with MySQL DB:
изображение

@yurem
Copy link
Contributor

yurem commented Nov 18, 2022

I've checked ORM + PostgreSQL/Spanner/CB.
According to my testing ORM with LDAP/CB/Spanner/MySQL/PostgreSQL correctly store/return values with next types: Boolean/Integer(Long)/Date. Multivalued attributes we store:

  1. As generic attributes in LDAP
  2. As JSON in MySQL/PostgreSQL
  3. As array in Spanner/CB.

@moabu
Copy link
Member Author

moabu commented Nov 21, 2022

This can be closed as resolved

@moabu moabu closed this as completed Nov 21, 2022
yurem added a commit that referenced this issue Dec 21, 2022
Co-authored-by: Yuriy Movchan <Yuriy.Movchan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-config-api Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants