Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-auth-server): npe - regression in token endpoint #2762

Closed
yuriyz opened this issue Oct 28, 2022 · 0 comments · Fixed by #2763
Closed

fix(jans-auth-server): npe - regression in token endpoint #2762

yuriyz opened this issue Oct 28, 2022 · 0 comments · Fixed by #2763
Assignees
@yuriyz
Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Milestone
1.0.3

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Oct 28, 2022

Describe the bug
We got regression in recent commits in Token Endpoint. NPE.

2022-10-28 12:44:07,205 ERROR [qtp1549725679-14] 7211fc8d-9ee5-4d64-9674-5fab88f0fc4e [as.server.token.ws.rs.TokenRestWebServiceImpl] (TokenRestWebServiceImpl.java:214) - null
java.lang.NullPointerException: null
        at io.jans.as.server.token.ws.rs.TokenExchangeService.putNewDeviceSecret(TokenExchangeService.java:176) ~[classes/:?]
        at io.jans.as.server.token.ws.rs.TokenRestWebServiceImpl.processAuthorizationCode(TokenRestWebServiceImpl.java:432) ~[classes/:?]
        at io.jans.as.server.token.ws.rs.TokenRestWebServiceImpl.requestAccessToken(TokenRestWebServiceImpl.java:196) ~[classes/:?]
        at io.jans.as.server.token.ws.rs.TokenRestWebServiceImpl$Proxy$_$$_WeldClientProxy.requestAccessToken(Unknown Source) ~[classes/:?]
        at jdk.internal.reflect.GeneratedMethodAccessor596.invoke(Unknown Source) ~[?:?]
        at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
        at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
        at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:170) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:130) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.ResourceMethodInvoker.internalInvokeOnTarget(ResourceMethodInvoker.java:660) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTargetAfterFilter(ResourceMethodInvoker.java:524) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.ResourceMethodInvoker.lambda$invokeOnTarget$2(ResourceMethodInvoker.java:474) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:364) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTarget(ResourceMethodInvoker.java:476) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:434) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:408) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:69) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:492) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.SynchronousDispatcher.lambda$invoke$4(SynchronousDispatcher.java:261) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.SynchronousDispatcher.lambda$preprocess$0(SynchronousDispatcher.java:161) ~[resteasy-core-6.0.3.Final.jar:6.0.3.Final]
        at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:364) ~[resteasy-core-6.0.3

To Reproduce
Invoke Token Endpoint with valid parameters.

Expected behavior
If valid parameters are provided, tokens must be returned
@yuriyz yuriyz added kind-bug Issue or PR is a bug in existing functionality comp-jans-auth-server Component affected by issue or PR labels Oct 28, 2022
@yuriyz yuriyz added this to the 1.0.3 milestone Oct 28, 2022
@yuriyz yuriyz self-assigned this Oct 28, 2022
yuriyz added a commit that referenced this issue Oct 28, 2022
@yuriyz
fix(jans-auth-server): npe - regression in token endpoint
e4064a9 
Native SSO

#2518
#2762
@yuriyz yuriyz mentioned this issue Oct 28, 2022
Merged
5 tasks
yuriyz added a commit that referenced this issue Oct 28, 2022
@yuriyz
fix(jans-auth-server): added test for npe fix
afaa776 
Native SSO

#2518
#2762
yuriyz added a commit that referenced this issue Oct 28, 2022
@yuriyz
fix(jans-auth-server): npe - regression in token endpoint (#2763)
fe659d7 
* fix(jans-auth-server): npe - regression in token endpoint

Native SSO

#2518
#2762

* fix(jans-auth-server): added test for npe fix

Native SSO

#2518
#2762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
comp-jans-auth-server Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

fix(jans-auth-server): npe - regression in token endpoint JanssenProject/jans
1 participant
@yuriyz