Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jans-fido2): NPE for U2f only devices and logging messages twice #2971

Closed
maduvena opened this issue Nov 14, 2022 · 0 comments · Fixed by #2972
Closed

fix(jans-fido2): NPE for U2f only devices and logging messages twice #2971

maduvena opened this issue Nov 14, 2022 · 0 comments · Fixed by #2972
Assignees
@maduvena
Labels
comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality

Comments

@maduvena
Copy link
Contributor

Two issues:

  1. When a u2f only device is registered, NPE is thrown during attestation
  2. All messages are logged twice
@maduvena maduvena assigned moabu and maduvena and unassigned moabu Nov 14, 2022
@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Nov 14, 2022
maduvena added a commit that referenced this issue Nov 14, 2022
@maduvena
fix(jans-fido2): #2971
629cded
@maduvena maduvena mentioned this issue Nov 14, 2022
Merged
@moabu moabu added this to the 1.0.5 milestone Nov 14, 2022
yurem pushed a commit that referenced this issue Nov 14, 2022
@maduvena
fix(jans-fido2): #2971 (#2972)
2f15cf8
This was referenced Dec 1, 2022
Merged
Merged
@mo-auto3 mo-auto3 mentioned this issue Dec 1, 2022
Merged
This was referenced Jan 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maduvena maduvena

Labels
comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(jans-fido2): #2971 JanssenProject/jans
3 participants
@maduvena @moabu @mo-auto